third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp - Issue 1937043002: Remove the LayoutSVGInlineText* context in SVGTextLayoutAttributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp

Issue 1937043002: Remove the LayoutSVGInlineText* context in SVGTextLayoutAttributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h ('k') | third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp

index 5c24881104914686ca4c676ace92dd19486119ab..f2c8cd5fe00a874ac796e3f0da51ff2c78b886fb 100644

--- a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp

@@ -30,8 +30,8 @@ namespace {

void updateLayoutAttributes(LayoutSVGInlineText& text, unsigned& valueListPosition, const SVGCharacterDataMap& allCharactersMap)

{

- SVGTextLayoutAttributes& attributes = *text.layoutAttributes();

- attributes.clear();

+ SVGCharacterDataMap& characterDataMap = text.characterDataMap();

+ characterDataMap.clear();

const Vector<SVGTextMetrics>& metricsList = text.metricsList();

auto metricsEnd = metricsList.end();

@@ -42,7 +42,7 @@ void updateLayoutAttributes(LayoutSVGInlineText& text, unsigned& valueListPositi

auto it = allCharactersMap.find(valueListPosition + 1);

if (it != allCharactersMap.end())

- attributes.characterDataMap().set(currentPosition + 1, it->value);

+ characterDataMap.set(currentPosition + 1, it->value);

// Increase the position in the value/attribute list with one for each

// "character unit" (that will be displayed.)