Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1936763002: [Extensions UI] Fix a bug in the extension message bubbles (Closed)

Created:
4 years, 7 months ago by Devlin
Modified:
4 years, 7 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions UI] Fix a bug in the extension message bubbles We weren't calling OnShown(), so message bubbles weren't recording that they were displayed for a given profile. Fix, and add a regression test. BUG=607099 TBR=avi@chromium.org (micro change to extension_message_bubble_browsertest_mac.mm) Committed: https://crrev.com/6b011081f35728dd3bcebc4fe894ed2542d960da Cr-Commit-Position: refs/heads/master@{#391305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/extensions/extension_message_bubble_bridge.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/extensions/extension_message_bubble_browsertest.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Devlin
Finnur, mind taking a look? Our favorite "one line fix, 40 line test" combo.
4 years, 7 months ago (2016-04-29 23:09:43 UTC) #2
Devlin
On 2016/04/29 23:09:43, Devlin wrote: > Finnur, mind taking a look? Our favorite "one line ...
4 years, 7 months ago (2016-05-03 05:26:03 UTC) #3
Finnur
LGTM. (Sorry for the late reply, I was OOO Friday and Monday and forgot to ...
4 years, 7 months ago (2016-05-03 09:00:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936763002/1
4 years, 7 months ago (2016-05-03 17:46:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/176848)
4 years, 7 months ago (2016-05-03 17:56:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936763002/1
4 years, 7 months ago (2016-05-03 18:15:45 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 18:24:43 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 18:26:21 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b011081f35728dd3bcebc4fe894ed2542d960da
Cr-Commit-Position: refs/heads/master@{#391305}

Powered by Google App Engine
This is Rietveld 408576698