Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3949)

Unified Diff: chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc

Issue 1936763002: [Extensions UI] Fix a bug in the extension message bubbles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc
diff --git a/chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc b/chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc
index f91011f291b651f9f655a92923b142d1dfede237..00ce49a6795a613b289e8f945e07037ef3fb9d29 100644
--- a/chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc
+++ b/chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc
@@ -122,3 +122,24 @@ void ExtensionMessageBubbleBrowserTest::TestBubbleShowsOnStartup() {
CheckBubble(browser(), ANCHOR_BROWSER_ACTION);
CloseBubble(browser());
}
+
+void ExtensionMessageBubbleBrowserTest::TestDevModeBubbleIsntShownTwice() {
+ scoped_refptr<const extensions::Extension> action_extension =
+ extensions::extension_action_test_util::CreateActionExtension(
+ "action_extension",
+ extensions::extension_action_test_util::BROWSER_ACTION,
+ extensions::Manifest::UNPACKED);
+ extension_service()->AddExtension(action_extension.get());
+
+ Browser* second_browser = new Browser(Browser::CreateParams(profile()));
+ base::RunLoop().RunUntilIdle();
+
+ CheckBubble(second_browser, ANCHOR_BROWSER_ACTION);
+ CloseBubble(second_browser);
+ base::RunLoop().RunUntilIdle();
+
+ // The bubble was already shown, so it shouldn't be shown again.
+ Browser* third_browser = new Browser(Browser::CreateParams(profile()));
+ base::RunLoop().RunUntilIdle();
+ CheckBubbleIsNotPresent(third_browser);
+}

Powered by Google App Engine
This is Rietveld 408576698