chrome/browser/ui/extensions/extension_message_bubble_bridge.cc - Issue 1936763002: [Extensions UI] Fix a bug in the extension message bubbles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/extension_message_bubble_bridge.cc

Issue 1936763002: [Extensions UI] Fix a bug in the extension message bubbles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm ('k') | chrome/browser/ui/extensions/extension_message_bubble_browsertest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/extensions/extension_message_bubble_bridge.cc

diff --git a/chrome/browser/ui/extensions/extension_message_bubble_bridge.cc b/chrome/browser/ui/extensions/extension_message_bubble_bridge.cc

index 9efce4b0462fb03cbbabf03a7c46dd32366e2038..0611f3269d583a1a51f63197a16a0cf12b245a94 100644

--- a/chrome/browser/ui/extensions/extension_message_bubble_bridge.cc

+++ b/chrome/browser/ui/extensions/extension_message_bubble_bridge.cc

@@ -54,7 +54,9 @@ std::string ExtensionMessageBubbleBridge::GetAnchorActionId() {

: std::string();

}

-void ExtensionMessageBubbleBridge::OnBubbleShown() {}

+void ExtensionMessageBubbleBridge::OnBubbleShown() {

+ controller_->OnShown();

void ExtensionMessageBubbleBridge::OnBubbleClosed(CloseAction action) {

switch (action) {