Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Issue 1936533003: Layout Tests: Remove assert_will_be_idl_attribute() helper (Closed)

Created:
4 years, 7 months ago by jsbell
Modified:
4 years, 7 months ago
CC:
blink-reviews, chasej+watch_chromium.org, chromium-reviews, harkness+watch_chromium.org, iclelland+watch_chromium.org, jkarlin+watch_chromium.org, johnme+watch_chromium.org, mvanouwerkerk+watch_chromium.org, Peter Beverloo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Layout Tests: Remove assert_will_be_idl_attribute() helper Now that DOM attributes are on prototype chains, just use assert_idl_attribute(). BUG=43394 Committed: https://crrev.com/b832a84ce777bc4ea348c2e1eba7844e83f5bd8c Cr-Commit-Position: refs/heads/master@{#391046}

Patch Set 1 #

Patch Set 2 : Remove unused import #

Messages

Total messages: 9 (3 generated)
jsbell
mek@, jkarlin@ - please take a look? The SyncEvent's assertion was incorrect. I think I ...
4 years, 7 months ago (2016-04-29 19:09:17 UTC) #2
jkarlin
background_sync/ lgtm. Thanks!
4 years, 7 months ago (2016-05-02 15:43:43 UTC) #3
Marijn Kruisselbrink
lgtm
4 years, 7 months ago (2016-05-02 17:33:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936533003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936533003/20001
4 years, 7 months ago (2016-05-02 17:37:47 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-02 20:36:12 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 20:38:40 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b832a84ce777bc4ea348c2e1eba7844e83f5bd8c
Cr-Commit-Position: refs/heads/master@{#391046}

Powered by Google App Engine
This is Rietveld 408576698