Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: third_party/WebKit/LayoutTests/resources/testharness-helpers.js

Issue 1936533003: Layout Tests: Remove assert_will_be_idl_attribute() helper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused import Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/resources/testharness-helpers.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/resources/testharness-helpers.js
diff --git a/third_party/WebKit/LayoutTests/resources/testharness-helpers.js b/third_party/WebKit/LayoutTests/resources/testharness-helpers.js
index 12960e30ac8ce9423dc11c7bea9841cec950f012..1d7b8c85b7dca5a4f4532f805731dbc0750ca495 100644
--- a/third_party/WebKit/LayoutTests/resources/testharness-helpers.js
+++ b/third_party/WebKit/LayoutTests/resources/testharness-helpers.js
@@ -32,28 +32,6 @@ function assert_promise_rejects(promise, code, description) {
});
}
-// Asserts that |object| that is an instance of some interface has the attribute
-// |attribute_name| following the conditions specified by WebIDL, but it's
-// acceptable that the attribute |attribute_name| is an own property of the
-// object because we're in the middle of moving the attribute to a prototype
-// chain. Once we complete the transition to prototype chains,
-// assert_will_be_idl_attribute must be replaced with assert_idl_attribute
-// defined in testharness.js.
-//
-// FIXME: Remove assert_will_be_idl_attribute once we complete the transition
-// of moving the DOM attributes to prototype chains. (http://crbug.com/43394)
-function assert_will_be_idl_attribute(object, attribute_name, description) {
- assert_true(typeof object === "object", description);
-
- assert_true("hasOwnProperty" in object, description);
-
- // Do not test if |attribute_name| is not an own property because
- // |attribute_name| is in the middle of the transition to a prototype
- // chain. (http://crbug.com/43394)
-
- assert_true(attribute_name in object, description);
-}
-
// Stringifies a DOM object. This function stringifies not only own properties
// but also DOM attributes which are on a prototype chain. Note that
// JSON.stringify only stringifies own properties.
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/resources/testharness-helpers.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698