Layout Tests: Remove stringifyDOMObject() helper

Layout Tests: Remove stringifyDOMObject() helper

This generic helper has been historically problematic, since
subtleties such as inherited vs. own-properties, serialization of
nested DOM objects, changes to base types, etc. makes it fragile.
We've eliminated all but one use, so it's time to go.

The final use (in notifications tests) which used this helper plus
JSON.parse() to do a deep clone is replaced by a dedicated cloning
function capturing the specific semantics needed for the test.

R=peter@chromium.org
BUG=467366
Committed: https://crrev.com/1a5019c2282bbbd1a69c266c0e9b2e237caa234c
Cr-Commit-Position: refs/heads/master@{#391252}

[jsbell, 2016-04-29 19:43:24]

jsbell@chromium.org changed reviewers:
- mek@chromium.org, yukishiino@chromium.org

[jsbell, 2016-04-29 19:43:25]

peter@ - please take a look?

[jsbell, 2016-04-29 19:43:52]

Description was changed from

==========
Layout Tests: Remove stringifyDOMObject() helper

This generic helper has been historically problematic, since
subtleties such as inherited vs. own-properties, serialization of
nested DOM objects, changes to base types, etc. makes it fragile.
We've eliminated all but one use, so it's time to go.

The final use (in notifications tests) which used this helper plus
JSON.parse() to do a deep clone is replaced by a dedicated cloning
function capturing the specific semantics needed for the test.

R=mek@chromium.org,peter@chromium.org,yukishiino@chromium.org
BUG=467366
==========

to

==========
Layout Tests: Remove stringifyDOMObject() helper

This generic helper has been historically problematic, since
subtleties such as inherited vs. own-properties, serialization of
nested DOM objects, changes to base types, etc. makes it fragile.
We've eliminated all but one use, so it's time to go.

The final use (in notifications tests) which used this helper plus
JSON.parse() to do a deep clone is replaced by a dedicated cloning
function capturing the specific semantics needed for the test.

R=peter@chromium.org
BUG=467366
==========

[Peter Beverloo, 2016-05-03 12:54:11]

lgtm, thank you!

[jsbell, 2016-05-03 14:49:10]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2016-05-03 14:49:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1935703003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1935703003/20001

[commit-bot: I haz the power, 2016-05-03 16:19:12]

Description was changed from

==========
Layout Tests: Remove stringifyDOMObject() helper

This generic helper has been historically problematic, since
subtleties such as inherited vs. own-properties, serialization of
nested DOM objects, changes to base types, etc. makes it fragile.
We've eliminated all but one use, so it's time to go.

The final use (in notifications tests) which used this helper plus
JSON.parse() to do a deep clone is replaced by a dedicated cloning
function capturing the specific semantics needed for the test.

R=peter@chromium.org
BUG=467366
==========

to

==========
Layout Tests: Remove stringifyDOMObject() helper

This generic helper has been historically problematic, since
subtleties such as inherited vs. own-properties, serialization of
nested DOM objects, changes to base types, etc. makes it fragile.
We've eliminated all but one use, so it's time to go.

The final use (in notifications tests) which used this helper plus
JSON.parse() to do a deep clone is replaced by a dedicated cloning
function capturing the specific semantics needed for the test.

R=peter@chromium.org
BUG=467366
==========

[commit-bot: I haz the power, 2016-05-03 16:19:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-03 16:21:45]

Description was changed from

==========
Layout Tests: Remove stringifyDOMObject() helper

This generic helper has been historically problematic, since
subtleties such as inherited vs. own-properties, serialization of
nested DOM objects, changes to base types, etc. makes it fragile.
We've eliminated all but one use, so it's time to go.

The final use (in notifications tests) which used this helper plus
JSON.parse() to do a deep clone is replaced by a dedicated cloning
function capturing the specific semantics needed for the test.

R=peter@chromium.org
BUG=467366
==========

to

==========
Layout Tests: Remove stringifyDOMObject() helper

This generic helper has been historically problematic, since
subtleties such as inherited vs. own-properties, serialization of
nested DOM objects, changes to base types, etc. makes it fragile.
We've eliminated all but one use, so it's time to go.

The final use (in notifications tests) which used this helper plus
JSON.parse() to do a deep clone is replaced by a dedicated cloning
function capturing the specific semantics needed for the test.

R=peter@chromium.org
BUG=467366

Committed: https://crrev.com/1a5019c2282bbbd1a69c266c0e9b2e237caa234c
Cr-Commit-Position: refs/heads/master@{#391252}
==========

[commit-bot: I haz the power, 2016-05-03 16:21:46]

Patchset 2 (id:??) landed as
https://crrev.com/1a5019c2282bbbd1a69c266c0e9b2e237caa234c
Cr-Commit-Position: refs/heads/master@{#391252}