Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 1936413002: Reland Don't assert rect mapping result if impossible (Closed)

Created:
4 years, 7 months ago by Xianzhu
Modified:
4 years, 7 months ago
Reviewers:
chrishtr
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland Don't assert rect mapping result if impossible The original CL was reverted because it broke some perf bots. The reason is that the slow path misses ancestor overflow clipping for some absolute-position object whose paint invalidation container is under the absolute-position object's container. This CL reland the original CL but doesn't enable CHECK_FAST_PATH_SLOW_PATH_EQUALITY by default. Avoid rect mapping result checking in the following cases: - Any rect may contain saturated values; - If a fixed-position ancestor disabled clipping. BUG=591199 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_dbg,mac_blink_dbg,win_blink_dbg TBR=chrishtr@chromium.org Review-Url: https://codereview.chromium.org/1859833002 Cr-Commit-Position: refs/heads/master@{#390814} Committed: https://crrev.com/0ddd48d1a4f271d3109019d55fe111a3220f1331 Cr-Commit-Position: refs/heads/master@{#391145}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -56 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.h View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp View 9 chunks +73 lines, -53 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936413002/1
4 years, 7 months ago (2016-05-02 21:43:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 01:30:28 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 01:32:14 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ddd48d1a4f271d3109019d55fe111a3220f1331
Cr-Commit-Position: refs/heads/master@{#391145}

Powered by Google App Engine
This is Rietveld 408576698