Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1859833002: Don't assert rect mapping result if impossible, and enable assert in debug build (Closed)

Created:
4 years, 8 months ago by Xianzhu
Modified:
4 years, 7 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@SVGRootClip
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't assert rect mapping result if impossible, and enable assert in debug build Avoid rect mapping result checking in the following cases: - Any rect may contain saturated values; - If a fixed-position ancestor disabled clipping. BUG=591199 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_dbg,mac_blink_dbg,win_blink_dbg Committed: https://crrev.com/c46c639d88881940f8ce4cb2fe6b50c41739d9de Cr-Commit-Position: refs/heads/master@{#390814}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Patch Set 13 : #

Patch Set 14 : #

Patch Set 15 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -56 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 9 chunks +73 lines, -53 lines 0 comments Download

Messages

Total messages: 26 (16 generated)
Xianzhu
4 years, 7 months ago (2016-04-29 19:43:25 UTC) #7
chrishtr
lgtm
4 years, 7 months ago (2016-04-29 21:22:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859833002/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859833002/280001
4 years, 7 months ago (2016-04-29 21:22:28 UTC) #10
commit-bot: I haz the power
Transient error: Invalid delimiter in "linux_blink_dbg,mac_blink_dbg,win_blink_dbg": Correct syntax is "tryserver:bot1,bot2;tryserver2:bot3,bot4;".
4 years, 7 months ago (2016-04-29 21:22:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859833002/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859833002/280001
4 years, 7 months ago (2016-04-29 21:28:38 UTC) #15
commit-bot: I haz the power
Transient error: Too many "tryserver.blink:linux_blink_dbg,tryserver.blink:mac_blink_dbg,tryserver.blink:win_blink_dbg" delimiters in ":". Correct syntax is "tryserver:bot1,bot2;tryserver2:bot3,bot4;".
4 years, 7 months ago (2016-04-29 21:28:40 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859833002/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859833002/280001
4 years, 7 months ago (2016-04-29 21:54:48 UTC) #20
commit-bot: I haz the power
Committed patchset #15 (id:280001)
4 years, 7 months ago (2016-04-30 00:09:54 UTC) #22
Dirk Pranke
A revert of this CL (patchset #15 id:280001) has been created in https://codereview.chromium.org/1934863002/ by dpranke@chromium.org. ...
4 years, 7 months ago (2016-04-30 01:47:54 UTC) #23
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:30:24 UTC) #24
Message was sent while issue was closed.
Patchset 15 (id:??) landed as
https://crrev.com/c46c639d88881940f8ce4cb2fe6b50c41739d9de
Cr-Commit-Position: refs/heads/master@{#390814}

Powered by Google App Engine
This is Rietveld 408576698