Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 1935593004: Extract WebWidgetTestClient out of WebTestProxyBase and WebViewTestClient. (Closed)

Created:
4 years, 7 months ago by Łukasz Anforowicz
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@test-runner-for-specific-view-separate
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract WebWidgetTestClient out of WebTestProxyBase and WebViewTestClient. This CL is part of a sequence of CLs that make progress toward: splitting WebTestProxyBase into separate WebFrameClient / WebWidgetClient / WebViewClient focused classes. This CL is similar to https://crrev.com/1840823002 (which extracted WebViewTestClient out of WebTestProxyBase) and https://crrev.com/1847893002 (which extracted WebFrameTestClient out of WebTestProxyBase). This CL in turn extracts WebWidgetTestClient out of WebTestProxyBase (and also out of WebViewTestClient accidentally included quite a few methods which were overriding WebWidgetClient, rather than WebViewClient). BUG=595089 Committed: https://crrev.com/df92022f3fc9037b1a584f2badc4ef308b705dfe Cr-Commit-Position: refs/heads/master@{#391264}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -117 lines) Patch
M components/test_runner/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/test_runner/test_runner.h View 3 chunks +4 lines, -3 lines 0 comments Download
M components/test_runner/test_runner.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M components/test_runner/test_runner.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M components/test_runner/web_test_interfaces.h View 2 chunks +8 lines, -0 lines 0 comments Download
M components/test_runner/web_test_interfaces.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M components/test_runner/web_test_proxy.h View 6 chunks +39 lines, -21 lines 0 comments Download
M components/test_runner/web_test_proxy.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M components/test_runner/web_view_test_client.h View 3 chunks +0 lines, -14 lines 0 comments Download
M components/test_runner/web_view_test_client.cc View 2 chunks +1 line, -62 lines 0 comments Download
A components/test_runner/web_widget_test_client.h View 1 chunk +62 lines, -0 lines 0 comments Download
A components/test_runner/web_widget_test_client.cc View 1 chunk +112 lines, -0 lines 0 comments Download
M content/shell/renderer/layout_test/layout_test_content_renderer_client.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebWidgetClient.h View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
Łukasz Anforowicz
jochen@, could you please take a look?
4 years, 7 months ago (2016-05-02 23:49:40 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-03 11:01:48 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935593004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935593004/1
4 years, 7 months ago (2016-05-03 15:01:11 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 16:23:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935593004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935593004/1
4 years, 7 months ago (2016-05-03 16:37:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 16:42:42 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 16:44:04 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df92022f3fc9037b1a584f2badc4ef308b705dfe
Cr-Commit-Position: refs/heads/master@{#391264}

Powered by Google App Engine
This is Rietveld 408576698