Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1931833003: Moving TestRunnerForSpecificView into a separate compilation unit. (Closed)

Created:
4 years, 7 months ago by Łukasz Anforowicz
Modified:
4 years, 7 months ago
CC:
chromium-reviews, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moving TestRunnerForSpecificView into a separate compilation unit. BUG=595089 Committed: https://crrev.com/c360bb3480742cb303d9693cfc12b72a3d701693 Cr-Commit-Position: refs/heads/master@{#391254}

Patch Set 1 #

Patch Set 2 : Removed no longer needed TODO + uploading with similarity=15%. #

Patch Set 3 : Rebasing... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+451 lines, -4565 lines) Patch
M components/test_runner/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M components/test_runner/test_common.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/test_runner/test_common.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M components/test_runner/test_runner.h View 1 2 4 chunks +0 lines, -199 lines 0 comments Download
M components/test_runner/test_runner.cc View 1 2 16 chunks +2 lines, -601 lines 0 comments Download
M components/test_runner/test_runner.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/test_runner/test_runner_for_specific_view.h View 1 2 3 chunks +6 lines, -626 lines 0 comments Download
A + components/test_runner/test_runner_for_specific_view.cc View 1 2 3 chunks +426 lines, -3139 lines 0 comments Download
M components/test_runner/web_test_proxy.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/test_runner/web_view_test_client.cc View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1935593004 Patch 1

Messages

Total messages: 8 (3 generated)
Łukasz Anforowicz
jochen@, could you please take a look? This is a mostly mechanical move of TestRunnerForSpecificView ...
4 years, 7 months ago (2016-04-28 20:46:52 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-02 16:17:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931833003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931833003/40001
4 years, 7 months ago (2016-05-03 15:00:55 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-03 16:20:42 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 16:23:29 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/c360bb3480742cb303d9693cfc12b72a3d701693
Cr-Commit-Position: refs/heads/master@{#391254}

Powered by Google App Engine
This is Rietveld 408576698