Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: components/test_runner/web_view_test_client.cc

Issue 1935593004: Extract WebWidgetTestClient out of WebTestProxyBase and WebViewTestClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test-runner-for-specific-view-separate
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/web_view_test_client.h ('k') | components/test_runner/web_widget_test_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/web_view_test_client.cc
diff --git a/components/test_runner/web_view_test_client.cc b/components/test_runner/web_view_test_client.cc
index 8f81d82402ded5f5d1db6eec4613e9f60811da2f..b52af0b09ed4d30ab051b729a1e244d87d196cd3 100644
--- a/components/test_runner/web_view_test_client.cc
+++ b/components/test_runner/web_view_test_client.cc
@@ -31,46 +31,13 @@ namespace test_runner {
WebViewTestClient::WebViewTestClient(TestRunner* test_runner,
WebTestProxyBase* web_test_proxy_base)
: test_runner_(test_runner),
- web_test_proxy_base_(web_test_proxy_base),
- animation_scheduled_(false),
- weak_factory_(this) {
+ web_test_proxy_base_(web_test_proxy_base) {
DCHECK(test_runner);
DCHECK(web_test_proxy_base);
}
WebViewTestClient::~WebViewTestClient() {}
-void WebViewTestClient::scheduleAnimation() {
- if (!test_runner_->TestIsRunning())
- return;
-
- if (!animation_scheduled_) {
- animation_scheduled_ = true;
- test_runner_->OnAnimationScheduled(web_test_proxy_base_->web_view());
-
- delegate()->PostDelayedTask(
- new WebCallbackTask(base::Bind(&WebViewTestClient::AnimateNow,
- weak_factory_.GetWeakPtr())),
- 1);
- }
-}
-
-void WebViewTestClient::AnimateNow() {
- if (animation_scheduled_) {
- blink::WebWidget* web_widget = web_test_proxy_base_->web_widget();
- animation_scheduled_ = false;
- test_runner_->OnAnimationBegun(web_test_proxy_base_->web_view());
-
- base::TimeDelta animate_time = base::TimeTicks::Now() - base::TimeTicks();
- web_widget->beginFrame(animate_time.InSecondsF());
- web_widget->updateAllLifecyclePhases();
- if (blink::WebPagePopup* popup = web_widget->pagePopup()) {
- popup->beginFrame(animate_time.InSecondsF());
- popup->updateAllLifecyclePhases();
- }
- }
-}
-
void WebViewTestClient::startDragging(blink::WebLocalFrame* frame,
const blink::WebDragData& data,
blink::WebDragOperationsMask mask,
@@ -179,34 +146,6 @@ blink::WebSpeechRecognizer* WebViewTestClient::speechRecognizer() {
return test_runner_->getMockWebSpeechRecognizer();
}
-bool WebViewTestClient::requestPointerLock() {
- return web_test_proxy_base_->view_test_runner()->RequestPointerLock();
-}
-
-void WebViewTestClient::requestPointerUnlock() {
- web_test_proxy_base_->view_test_runner()->RequestPointerUnlock();
-}
-
-bool WebViewTestClient::isPointerLocked() {
- return web_test_proxy_base_->view_test_runner()->isPointerLocked();
-}
-
-void WebViewTestClient::didFocus() {
- test_runner_->SetFocus(web_test_proxy_base_->web_view(), true);
-}
-
-void WebViewTestClient::setToolTipText(const blink::WebString& text,
- blink::WebTextDirection direction) {
- test_runner_->setToolTipText(text);
-}
-
-void WebViewTestClient::resetInputMethod() {
- // If a composition text exists, then we need to let the browser process
- // to cancel the input method's ongoing composition session.
- if (web_test_proxy_base_)
- web_test_proxy_base_->web_widget()->confirmComposition();
-}
-
blink::WebString WebViewTestClient::acceptLanguages() {
return blink::WebString::fromUTF8(test_runner_->GetAcceptLanguages());
}
« no previous file with comments | « components/test_runner/web_view_test_client.h ('k') | components/test_runner/web_widget_test_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698