Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1935413003: [Android Bookmark] Remove all bookmark section from bookmark manager (Closed)

Created:
4 years, 7 months ago by Ian Wen
Modified:
4 years, 7 months ago
Reviewers:
rkaplow, gone
CC:
chromium-reviews, noyau+watch_chromium.org, browser-components-watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android Bookmark] Remove all bookmark section from bookmark manager This CL removes ALL_BOOKMARK state from BookmarkUIState, and cleaned up all the related functions in bookmark manager and bridge. After this CL, a new user will land on mobile bookmark folder when he/she opens the bookmark manager. If he has previously opened another folder, the bookmark manager remembers the previous folder. BUG=605614 Committed: https://crrev.com/9aa0bf1f4c14e938f02ca7c5e7b2ec4de6c7b2b8 Cr-Commit-Position: refs/heads/master@{#391675}

Patch Set 1 #

Patch Set 2 : make search available in every folder #

Total comments: 4

Patch Set 3 : make a histogram obsolete #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -236 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/UrlConstants.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActionBar.java View 1 1 chunk +2 lines, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBridge.java View 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkContentView.java View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkDelegate.java View 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkDrawerListView.java View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkDrawerListViewAdapter.java View 1 2 8 chunks +8 lines, -21 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemRow.java View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java View 4 chunks +2 lines, -15 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkLaunchLocation.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java View 6 chunks +3 lines, -17 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRecyclerView.java View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkSearchView.java View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUIObserver.java View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUIState.java View 4 chunks +3 lines, -11 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkModelTest.java View 2 chunks +0 lines, -32 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/bookmarks/bookmark_bridge.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/android/bookmarks/bookmark_bridge.cc View 2 chunks +0 lines, -54 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
Ian Wen
PTAL :)
4 years, 7 months ago (2016-05-03 22:06:44 UTC) #2
gone
https://chromiumcodereview.appspot.com/1935413003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkDrawerListViewAdapter.java File chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkDrawerListViewAdapter.java (right): https://chromiumcodereview.appspot.com/1935413003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkDrawerListViewAdapter.java#newcode37 chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkDrawerListViewAdapter.java:37: private List<?>[] mSections = {mTopSection, mMiddleSection}; Kind of weird ...
4 years, 7 months ago (2016-05-04 18:21:52 UTC) #4
gone
lgtm
4 years, 7 months ago (2016-05-04 18:21:57 UTC) #5
Ian Wen
Hi Robert: could you PTAL at the change in histogram? :) https://codereview.chromium.org/1935413003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkDrawerListViewAdapter.java File chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkDrawerListViewAdapter.java (right): ...
4 years, 7 months ago (2016-05-04 20:21:55 UTC) #7
rkaplow
lgtm
4 years, 7 months ago (2016-05-04 21:01:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935413003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935413003/40001
4 years, 7 months ago (2016-05-04 21:28:15 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-04 22:59:25 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 23:00:59 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9aa0bf1f4c14e938f02ca7c5e7b2ec4de6c7b2b8
Cr-Commit-Position: refs/heads/master@{#391675}

Powered by Google App Engine
This is Rietveld 408576698