Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java

Issue 1935413003: [Android Bookmark] Remove all bookmark section from bookmark manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make a histogram obsolete Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java
index 7edde5f94ee586236805bbbb1318e0860ada91d0..20cc2237882bdea2ec75117301d71eb62ab69b31 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java
@@ -12,7 +12,6 @@ import android.view.View;
import android.view.ViewGroup;
import org.chromium.base.annotations.SuppressFBWarnings;
-import org.chromium.base.metrics.RecordHistogram;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.bookmarks.BookmarkBridge.BookmarkItem;
import org.chromium.chrome.browser.bookmarks.BookmarkBridge.BookmarkModelObserver;
@@ -244,8 +243,7 @@ class BookmarkItemsAdapter extends RecyclerView.Adapter<RecyclerView.ViewHolder>
@Override
public void onPromoHeaderShowingChanged(boolean isShowing) {
assert mDelegate != null;
- if (mDelegate.getCurrentState() != BookmarkUIState.STATE_ALL_BOOKMARKS
- && mDelegate.getCurrentState() != BookmarkUIState.STATE_FOLDER) {
+ if (mDelegate.getCurrentState() != BookmarkUIState.STATE_FOLDER) {
return;
}
@@ -274,16 +272,6 @@ class BookmarkItemsAdapter extends RecyclerView.Adapter<RecyclerView.ViewHolder>
}
@Override
- public void onAllBookmarksStateSet() {
- assert mDelegate != null;
- List<BookmarkId> bookmarkIds =
- mDelegate.getModel().getAllBookmarkIDsOrderedByCreationDate();
- RecordHistogram.recordCountHistogram("EnhancedBookmarks.AllBookmarksCount",
- bookmarkIds.size());
- setBookmarks(null, bookmarkIds);
- }
-
- @Override
public void onFolderStateSet(BookmarkId folder) {
assert mDelegate != null;
setBookmarks(mDelegate.getModel().getChildIDs(folder, true, false),
@@ -306,8 +294,7 @@ class BookmarkItemsAdapter extends RecyclerView.Adapter<RecyclerView.ViewHolder>
if (currentUIState == BookmarkUIState.STATE_LOADING) return;
mPromoHeaderSection.clear();
- assert currentUIState == BookmarkUIState.STATE_ALL_BOOKMARKS
- || currentUIState == BookmarkUIState.STATE_FOLDER : "Unexpected UI state";
+ assert currentUIState == BookmarkUIState.STATE_FOLDER : "Unexpected UI state";
if (mPromoHeaderManager.shouldShow()) {
mPromoHeaderSection.add(null);
}

Powered by Google App Engine
This is Rietveld 408576698