DevTools: [SASS] fix CSSWorkspaceBinding.propertyUILocation to account for comments

DevTools: [SASS] fix CSSWorkspaceBinding.propertyUILocation to account for comments

Current implementation of CSSWorkspaceBinding.propertyUILocation does
not account for comment characters.

BUG=none
R=pfeldman

Committed: https://crrev.com/6bd07d712bf0f6390281262d0a2caf8b2a1d3345
Cr-Commit-Position: refs/heads/master@{#391450}

[pfeldman, 2016-05-03 17:52:29]

https://codereview.chromium.org/1943763002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js
(right):

https://codereview.chromium.org/1943763002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js:136:
propertyUILocation: function(cssProperty, forName)
I don't think this method belongs here, lets move it to the call site.

https://codereview.chromium.org/1943763002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js:154:
textCursor.resetTo(valueIndex + cssProperty.value.length);
You want to accompany this with a test. Otherwise lgtm.

[lushnikov, 2016-05-03 23:19:27]

https://codereview.chromium.org/1943763002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js
(right):

https://codereview.chromium.org/1943763002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js:136:
propertyUILocation: function(cssProperty, forName)
On 2016/05/03 17:52:29, pfeldman wrote:
> I don't think this method belongs here, lets move it to the call site.

Introduced property.nameRange() and property.valueRange() methods

https://codereview.chromium.org/1943763002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js:154:
textCursor.resetTo(valueIndex + cssProperty.value.length);
On 2016/05/03 17:52:29, pfeldman wrote:
> You want to accompany this with a test. Otherwise lgtm.

Done.

[lushnikov, 2016-05-03 23:19:32]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-05-03 23:19:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1943763002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-05-03 23:19:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943763002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943763002/60001

[lushnikov, 2016-05-03 23:53:52]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-05-03 23:53:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1943763002/#ps80001
(title: "rebaseline")

[commit-bot: I haz the power, 2016-05-03 23:54:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943763002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943763002/80001

[commit-bot: I haz the power, 2016-05-04 01:22:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 01:22:43]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lushnikov, 2016-05-04 03:29:24]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-05-04 03:29:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1943763002/#ps100001
(title: "fix tests")

[commit-bot: I haz the power, 2016-05-04 03:29:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943763002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943763002/100001

[commit-bot: I haz the power, 2016-05-04 05:15:33]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-05-04 05:16:54]

Description was changed from

==========
DevTools: [SASS] fix CSSWorkspaceBinding.propertyUILocation to account for
comments

Current implementation of CSSWorkspaceBinding.propertyUILocation does
not account for comment characters.

BUG=none
R=pfeldman
==========

to

==========
DevTools: [SASS] fix CSSWorkspaceBinding.propertyUILocation to account for
comments

Current implementation of CSSWorkspaceBinding.propertyUILocation does
not account for comment characters.

BUG=none
R=pfeldman

Committed: https://crrev.com/6bd07d712bf0f6390281262d0a2caf8b2a1d3345
Cr-Commit-Position: refs/heads/master@{#391450}
==========

[commit-bot: I haz the power, 2016-05-04 05:16:55]

Patchset 6 (id:??) landed as
https://crrev.com/6bd07d712bf0f6390281262d0a2caf8b2a1d3345
Cr-Commit-Position: refs/heads/master@{#391450}