Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1935113002:
Roll libjpeg-turbo to 1.4.90 and update gn file (Closed)
DescriptionRoll libjpeg-turbo to 1.4.90 and update gn file
Includes the following commits:
Add PRIVATE flags to global symbols
51655203fbc949e6423dcd13ce22fe30ab5b5ea2
Fix INLINE macro on Windows
9fee17f77cb7bf0f543f9f4a77b20edbde4c2c04
Update to libjpeg_turbo 1.4.90
0d47d2d3a728e78676a15b1d818cc668cb7e5a9c
Add default variable 'use_system_yasm%':
9d35298a6223278a66423f828a949d93d94d5911
Update README.chromium about the 32-bit argument patch
c653af70b7b2bbd3e8cd16c17bc2705cf25b1469
BUG=608347
Committed: https://crrev.com/346f74fb31a84f8453e885337e0765576b4f35b6
Cr-Commit-Position: refs/heads/master@{#391883}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : Run gn format #Patch Set 4 : Roll to Windows fix and PRIVATE assembly functions #
Total comments: 2
Patch Set 5 : Disable compiler warning on Win64 #Messages
Total messages: 43 (19 generated)
msarett@google.com changed reviewers: + noel@chromium.org, scroggo@chromium.org, thakis@chromium.org
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935113002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935113002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
Description was changed from ========== Update gn build for libjpeg-turbo 1.4.90 BUG=608347 ========== to ========== Roll libjpeg-turbo to 1.4.90 and update gn file BUG=608347 ==========
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935113002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935113002/60001
Please take a look!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Looks to me like the webkit layout tests were not run?
Let me see if I can add the blink trys (to run layout tests) ...
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935113002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935113002/60001
On 2016/05/05 16:13:22, noel gordon wrote: > Let me see if I can add the blink trys (to run layout tests) ... Great! Looks like they are added.
Yeah, looks like my change to automatically run blink layout tests when third_party image libs change [1] does not work when only the .gn is updated :( [1] https://bugs.chromium.org/p/chromium/issues/detail?id=597181#c7
LGTM I'd list the commits being picked up in the change description. I think you might pick up Frank's change as well ... https://chromium.googlesource.com/chromium/deps/libjpeg_turbo/+/9d35298a62232... from https://codereview.chromium.org/1866193002 I don't recall if it was rolled. Indeed, just checking, https://codereview.chromium.org/1352503002 was the last roll by the looks, commit e4e75037f29745f1546b6ebf5cf532e841c04c2c, which I see in your DEPS diff-left. Ping Frank. And thanks again Matt for taking this work on.
Description was changed from ========== Roll libjpeg-turbo to 1.4.90 and update gn file BUG=608347 ========== to ========== Roll libjpeg-turbo to 1.4.90 and update gn file Includes the following commits: master 51655203fbc949e6423dcd13ce22fe30ab5b5ea2 Add PRIVATE flags to global symbols 9fee17f77cb7bf0f543f9f4a77b20edbde4c2c04 Fix INLINE macro on Windows 0d47d2d3a728e78676a15b1d818cc668cb7e5a9c Update to libjpeg_turbo 1.4.90 9d35298a6223278a66423f828a949d93d94d5911 Add default variable 'use_system_yasm%': BUG=608347 ==========
Description was changed from ========== Roll libjpeg-turbo to 1.4.90 and update gn file Includes the following commits: master 51655203fbc949e6423dcd13ce22fe30ab5b5ea2 Add PRIVATE flags to global symbols 9fee17f77cb7bf0f543f9f4a77b20edbde4c2c04 Fix INLINE macro on Windows 0d47d2d3a728e78676a15b1d818cc668cb7e5a9c Update to libjpeg_turbo 1.4.90 9d35298a6223278a66423f828a949d93d94d5911 Add default variable 'use_system_yasm%': BUG=608347 ========== to ========== Roll libjpeg-turbo to 1.4.90 and update gn file Includes the following commits: 51655203fbc949e6423dcd13ce22fe30ab5b5ea2 Add PRIVATE flags to global symbols 9fee17f77cb7bf0f543f9f4a77b20edbde4c2c04 Fix INLINE macro on Windows 0d47d2d3a728e78676a15b1d818cc668cb7e5a9c Update to libjpeg_turbo 1.4.90 9d35298a6223278a66423f828a949d93d94d5911 Add default variable 'use_system_yasm%': BUG=608347 ==========
Description was changed from ========== Roll libjpeg-turbo to 1.4.90 and update gn file Includes the following commits: 51655203fbc949e6423dcd13ce22fe30ab5b5ea2 Add PRIVATE flags to global symbols 9fee17f77cb7bf0f543f9f4a77b20edbde4c2c04 Fix INLINE macro on Windows 0d47d2d3a728e78676a15b1d818cc668cb7e5a9c Update to libjpeg_turbo 1.4.90 9d35298a6223278a66423f828a949d93d94d5911 Add default variable 'use_system_yasm%': BUG=608347 ========== to ========== Roll libjpeg-turbo to 1.4.90 and update gn file Includes the following commits: Add PRIVATE flags to global symbols (51655203fbc949e6423dcd13ce22fe30ab5b5ea2) Fix INLINE macro on Windows (9fee17f77cb7bf0f543f9f4a77b20edbde4c2c04) Update to libjpeg_turbo 1.4.90 (0d47d2d3a728e78676a15b1d818cc668cb7e5a9c) Add default variable 'use_system_yasm%': (9d35298a6223278a66423f828a949d93d94d5911) Update README.chromium about the 32-bit argument patch (c653af70b7b2bbd3e8cd16c17bc2705cf25b1469) BUG=608347 ==========
msarett@google.com changed reviewers: + fbarchard@chromium.org
+fbarchard Since it looks like we'll be rolling in your commit as well.
https://codereview.chromium.org/1935113002/diff/60001/build/secondary/third_p... File build/secondary/third_party/libjpeg_turbo/BUILD.gn (right): https://codereview.chromium.org/1935113002/diff/60001/build/secondary/third_p... build/secondary/third_party/libjpeg_turbo/BUILD.gn:106: cflags = [ "/wd4245" ] looks like you need to move this out of the x86 if since the 64 bit build seems to complain about this warning too
Description was changed from ========== Roll libjpeg-turbo to 1.4.90 and update gn file Includes the following commits: Add PRIVATE flags to global symbols (51655203fbc949e6423dcd13ce22fe30ab5b5ea2) Fix INLINE macro on Windows (9fee17f77cb7bf0f543f9f4a77b20edbde4c2c04) Update to libjpeg_turbo 1.4.90 (0d47d2d3a728e78676a15b1d818cc668cb7e5a9c) Add default variable 'use_system_yasm%': (9d35298a6223278a66423f828a949d93d94d5911) Update README.chromium about the 32-bit argument patch (c653af70b7b2bbd3e8cd16c17bc2705cf25b1469) BUG=608347 ========== to ========== Roll libjpeg-turbo to 1.4.90 and update gn file Includes the following commits: Add PRIVATE flags to global symbols 51655203fbc949e6423dcd13ce22fe30ab5b5ea2 Fix INLINE macro on Windows 9fee17f77cb7bf0f543f9f4a77b20edbde4c2c04 Update to libjpeg_turbo 1.4.90 0d47d2d3a728e78676a15b1d818cc668cb7e5a9c Add default variable 'use_system_yasm%': 9d35298a6223278a66423f828a949d93d94d5911 Update README.chromium about the 32-bit argument patch c653af70b7b2bbd3e8cd16c17bc2705cf25b1469 BUG=608347 ==========
The CQ bit was checked by msarett@google.com to run a CQ dry run
https://codereview.chromium.org/1935113002/diff/60001/build/secondary/third_p... File build/secondary/third_party/libjpeg_turbo/BUILD.gn (right): https://codereview.chromium.org/1935113002/diff/60001/build/secondary/third_p... build/secondary/third_party/libjpeg_turbo/BUILD.gn:106: cflags = [ "/wd4245" ] On 2016/05/05 17:30:39, Nico wrote: > looks like you need to move this out of the x86 if since the 64 bit build seems > to complain about this warning too Nice catch! Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935113002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935113002/80001
lgtm if the bots are happy
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by msarett@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from noel@chromium.org Link to the patchset: https://codereview.chromium.org/1935113002/#ps80001 (title: "Disable compiler warning on Win64")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935113002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935113002/80001
Message was sent while issue was closed.
Description was changed from ========== Roll libjpeg-turbo to 1.4.90 and update gn file Includes the following commits: Add PRIVATE flags to global symbols 51655203fbc949e6423dcd13ce22fe30ab5b5ea2 Fix INLINE macro on Windows 9fee17f77cb7bf0f543f9f4a77b20edbde4c2c04 Update to libjpeg_turbo 1.4.90 0d47d2d3a728e78676a15b1d818cc668cb7e5a9c Add default variable 'use_system_yasm%': 9d35298a6223278a66423f828a949d93d94d5911 Update README.chromium about the 32-bit argument patch c653af70b7b2bbd3e8cd16c17bc2705cf25b1469 BUG=608347 ========== to ========== Roll libjpeg-turbo to 1.4.90 and update gn file Includes the following commits: Add PRIVATE flags to global symbols 51655203fbc949e6423dcd13ce22fe30ab5b5ea2 Fix INLINE macro on Windows 9fee17f77cb7bf0f543f9f4a77b20edbde4c2c04 Update to libjpeg_turbo 1.4.90 0d47d2d3a728e78676a15b1d818cc668cb7e5a9c Add default variable 'use_system_yasm%': 9d35298a6223278a66423f828a949d93d94d5911 Update README.chromium about the 32-bit argument patch c653af70b7b2bbd3e8cd16c17bc2705cf25b1469 BUG=608347 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Roll libjpeg-turbo to 1.4.90 and update gn file Includes the following commits: Add PRIVATE flags to global symbols 51655203fbc949e6423dcd13ce22fe30ab5b5ea2 Fix INLINE macro on Windows 9fee17f77cb7bf0f543f9f4a77b20edbde4c2c04 Update to libjpeg_turbo 1.4.90 0d47d2d3a728e78676a15b1d818cc668cb7e5a9c Add default variable 'use_system_yasm%': 9d35298a6223278a66423f828a949d93d94d5911 Update README.chromium about the 32-bit argument patch c653af70b7b2bbd3e8cd16c17bc2705cf25b1469 BUG=608347 ========== to ========== Roll libjpeg-turbo to 1.4.90 and update gn file Includes the following commits: Add PRIVATE flags to global symbols 51655203fbc949e6423dcd13ce22fe30ab5b5ea2 Fix INLINE macro on Windows 9fee17f77cb7bf0f543f9f4a77b20edbde4c2c04 Update to libjpeg_turbo 1.4.90 0d47d2d3a728e78676a15b1d818cc668cb7e5a9c Add default variable 'use_system_yasm%': 9d35298a6223278a66423f828a949d93d94d5911 Update README.chromium about the 32-bit argument patch c653af70b7b2bbd3e8cd16c17bc2705cf25b1469 BUG=608347 Committed: https://crrev.com/346f74fb31a84f8453e885337e0765576b4f35b6 Cr-Commit-Position: refs/heads/master@{#391883} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/346f74fb31a84f8453e885337e0765576b4f35b6 Cr-Commit-Position: refs/heads/master@{#391883}
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/1952363002/ by dskiba@google.com. The reason for reverting is: Broke Android x86 Builder (dbg): FAILED: libblimp_client_android.so libblimp_client_android.so.TOC lib.unstripped/libblimp_client_android.so ld.gold: warning: shared library text segment is not shareable ld.gold: error: treating warnings as errors https://build.chromium.org/p/chromium.android/builders/Android%20x86%20Builde... Reverting this change locally fixes the issue..
Message was sent while issue was closed.
On 2016/05/05 21:40:42, Dmitry Skiba wrote: > A revert of this CL (patchset #5 id:80001) has been created in > https://codereview.chromium.org/1952363002/ by mailto:dskiba@google.com. > > The reason for reverting is: Broke Android x86 Builder (dbg): > > FAILED: libblimp_client_android.so libblimp_client_android.so.TOC > lib.unstripped/libblimp_client_android.so > ld.gold: warning: shared library text segment is not shareable > ld.gold: error: treating warnings as errors > > https://build.chromium.org/p/chromium.android/builders/Android%20x86%20Builde... > > Reverting this change locally fixes the issue.. I think this means we just need to pass the PIC flag to yasm when compiling the assembly. Dmitry, did this break the gn or gyp build? Or both?
Message was sent while issue was closed.
Description was changed from ========== Roll libjpeg-turbo to 1.4.90 and update gn file Includes the following commits: Add PRIVATE flags to global symbols 51655203fbc949e6423dcd13ce22fe30ab5b5ea2 Fix INLINE macro on Windows 9fee17f77cb7bf0f543f9f4a77b20edbde4c2c04 Update to libjpeg_turbo 1.4.90 0d47d2d3a728e78676a15b1d818cc668cb7e5a9c Add default variable 'use_system_yasm%': 9d35298a6223278a66423f828a949d93d94d5911 Update README.chromium about the 32-bit argument patch c653af70b7b2bbd3e8cd16c17bc2705cf25b1469 BUG=608347 Committed: https://crrev.com/346f74fb31a84f8453e885337e0765576b4f35b6 Cr-Commit-Position: refs/heads/master@{#391883} ========== to ========== Roll libjpeg-turbo to 1.4.90 and update gn file Includes the following commits: Add PRIVATE flags to global symbols 51655203fbc949e6423dcd13ce22fe30ab5b5ea2 Fix INLINE macro on Windows 9fee17f77cb7bf0f543f9f4a77b20edbde4c2c04 Update to libjpeg_turbo 1.4.90 0d47d2d3a728e78676a15b1d818cc668cb7e5a9c Add default variable 'use_system_yasm%': 9d35298a6223278a66423f828a949d93d94d5911 Update README.chromium about the 32-bit argument patch c653af70b7b2bbd3e8cd16c17bc2705cf25b1469 BUG=608347 Committed: https://crrev.com/346f74fb31a84f8453e885337e0765576b4f35b6 Cr-Commit-Position: refs/heads/master@{#391883} ==========
Message was sent while issue was closed.
On 2016/05/05 21:46:39, msarett wrote: > On 2016/05/05 21:40:42, Dmitry Skiba wrote: > > A revert of this CL (patchset #5 id:80001) has been created in > > https://codereview.chromium.org/1952363002/ by mailto:dskiba@google.com. > > > > The reason for reverting is: Broke Android x86 Builder (dbg): > > > > FAILED: libblimp_client_android.so libblimp_client_android.so.TOC > > lib.unstripped/libblimp_client_android.so > > ld.gold: warning: shared library text segment is not shareable > > ld.gold: error: treating warnings as errors > > > > > https://build.chromium.org/p/chromium.android/builders/Android%20x86%20Builde... > > > > Reverting this change locally fixes the issue.. > > I think this means we just need to pass the PIC flag to yasm when compiling the > assembly. Dmitry, did this break the gn or gyp > build? Or both? We've managed to keep this in with the following build fix: https://codereview.chromium.org/1954903002/ Thanks Dmitry for testing/landing this! |
