Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1961933002:
Remove unused MJPEG define from libjpeg-turbo GN and GYP (Closed)
DescriptionRemove unused MJPEG define from libjpeg-turbo GN and GYP
libjpeg_turbo.gyp is located in third-party and is updated
by rolling to a recent commit:
414f243 Remove unused MJPEG define from libjpeg-turbo GYP file
414f2433e6634942b9ceea9450bdc21dcc5520cf
by Noel Gordon
BUG=608347
Committed: https://crrev.com/50a66e887857dc4117e64f5150c0bafc5097279e
Cr-Commit-Position: refs/heads/master@{#392934}
Patch Set 1 #Patch Set 2 : Rolls libjpeg_turbo for gyp update #Patch Set 3 : Rebase #Messages
Total messages: 42 (19 generated)
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961933002/1
msarett@google.com changed reviewers: + noel@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The gn change looks good, what about the gyp file?
I'm not a chromium committer, so if I uploaded a change to the gyp (in third_party), I would need someone to commit it for me. Given that it's a one line change, I think it makes more sense for a chromium committer to take it on. I posted something similar in the bug. https://bugs.chromium.org/p/chromium/issues/detail?id=608347
Description was changed from ========== Remove unused MJPEG define from libjpeg-turbo GN build BUG= ========== to ========== Remove unused MJPEG define from libjpeg-turbo GN build BUG=608347 ==========
On 2016/05/10 13:38:27, msarett wrote: > I'm not a chromium committer, so if I uploaded a change to the gyp (in > third_party), I would need someone to commit it for me. Same applies to the gn change, it's in third_party too ;) > Given that it's a one line change, I think it makes more sense for a chromium > committer to take it on. I posted something similar in the bug. > https://bugs.chromium.org/p/chromium/issues/detail?id=608347 Ah yes, read that _after_ review commenting here. Easiest thing to do is: -- upload one change that does both the gyp & gn -- submit that change, then roll chromium DEPS. Since you are not a chromium committer, lemme do that for you.
LGTM - and oic, the GN is stuff is in some other place, doh! build/secondary/third_party/libjpeg_turbo/BUILD.gn I will do the gyp part in another CL.
The CQ bit was checked by msarett@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961933002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
msarett@google.com changed reviewers: + thakis@chromium.org
I think the way this should work, to keep gyp and gn in sync, is to do this change in gyp in the jpeg_turbo repo first, and then roll that change in and do the change to gn in src in the same cl
Also, when adding people to the review later on, please add some text what you want them to do. Here's how the email I got for this looked like: http://imgur.com/W3Ktg57
On 2016/05/11 13:08:12, Nico wrote: > I think the way this should work, to keep gyp and gn in sync, is to do this > change in gyp in the jpeg_turbo repo first, and then roll that change in and do > the change to gn in src in the same cl SGTM
Description was changed from ========== Remove unused MJPEG define from libjpeg-turbo GN build BUG=608347 ========== to ========== Remove unused MJPEG define from libjpeg-turbo GN and GYP libjpeg_turbo.gyp is located in third-party and is updated by rolling to a recent commit: Remove unused MJPEG define from libjpeg-turbo GYP file by Noel Gordon BUG=608347 ==========
Description was changed from ========== Remove unused MJPEG define from libjpeg-turbo GN and GYP libjpeg_turbo.gyp is located in third-party and is updated by rolling to a recent commit: Remove unused MJPEG define from libjpeg-turbo GYP file by Noel Gordon BUG=608347 ========== to ========== Remove unused MJPEG define from libjpeg-turbo GN and GYP libjpeg_turbo.gyp is located in third-party and is updated by rolling to a recent commit: 414f243 Remove unused MJPEG define from libjpeg-turbo GYP file by Noel Gordon BUG=608347 ==========
PTAL. I've included the roll (with the gyp change in this CL).
lgtm
The CQ bit was checked by msarett@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from noel@chromium.org Link to the patchset: https://codereview.chromium.org/1961933002/#ps20001 (title: "Rolls libjpeg_turbo for gyp update")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961933002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961933002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961933002/40001
Description was changed from ========== Remove unused MJPEG define from libjpeg-turbo GN and GYP libjpeg_turbo.gyp is located in third-party and is updated by rolling to a recent commit: 414f243 Remove unused MJPEG define from libjpeg-turbo GYP file by Noel Gordon BUG=608347 ========== to ========== Remove unused MJPEG define from libjpeg-turbo GN and GYP libjpeg_turbo.gyp is located in third-party and is updated by rolling to a recent commit: 414f243 Remove unused MJPEG define from libjpeg-turbo GYP file 414f2433e6634942b9ceea9450bdc21dcc5520cf by Noel Gordon BUG=608347 ==========
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by msarett@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org Link to the patchset: https://codereview.chromium.org/1961933002/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961933002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961933002/40001
Message was sent while issue was closed.
Description was changed from ========== Remove unused MJPEG define from libjpeg-turbo GN and GYP libjpeg_turbo.gyp is located in third-party and is updated by rolling to a recent commit: 414f243 Remove unused MJPEG define from libjpeg-turbo GYP file 414f2433e6634942b9ceea9450bdc21dcc5520cf by Noel Gordon BUG=608347 ========== to ========== Remove unused MJPEG define from libjpeg-turbo GN and GYP libjpeg_turbo.gyp is located in third-party and is updated by rolling to a recent commit: 414f243 Remove unused MJPEG define from libjpeg-turbo GYP file 414f2433e6634942b9ceea9450bdc21dcc5520cf by Noel Gordon BUG=608347 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Remove unused MJPEG define from libjpeg-turbo GN and GYP libjpeg_turbo.gyp is located in third-party and is updated by rolling to a recent commit: 414f243 Remove unused MJPEG define from libjpeg-turbo GYP file 414f2433e6634942b9ceea9450bdc21dcc5520cf by Noel Gordon BUG=608347 ========== to ========== Remove unused MJPEG define from libjpeg-turbo GN and GYP libjpeg_turbo.gyp is located in third-party and is updated by rolling to a recent commit: 414f243 Remove unused MJPEG define from libjpeg-turbo GYP file 414f2433e6634942b9ceea9450bdc21dcc5520cf by Noel Gordon BUG=608347 Committed: https://crrev.com/50a66e887857dc4117e64f5150c0bafc5097279e Cr-Commit-Position: refs/heads/master@{#392934} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/50a66e887857dc4117e64f5150c0bafc5097279e Cr-Commit-Position: refs/heads/master@{#392934} |
