Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1269)

Issue 1866193002: Add default variable 'use_system_yasm%': 0 (Closed)

Created:
4 years, 8 months ago by fbarchard1
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add default variable 'use_system_yasm%': 0 When compiling for NaCL the following build error native_client/build/gyp_nacl all.gyp -Dgtest_target_type=executable -Dmsan=0 Updating projects from gyp files... gyp: name 'use_system_yasm' is not defined while evaluating condition 'use_system_yasm==1' in chromium/src/third_party/libjpeg_turbo/libjpeg.gyp Adding use_system_yasm=0 to the command line works. (use_system_yasm=1 does not work). Adding a default to the gyp file allows the build to work without specifying the default value for this variable. BUG=None TESTED=native_client/build/gyp_nacl all.gyp -Dgtest_target_type=executable -Dmsan=0 -Duse_system_yasm=0 R=kjellander@chromium.org, noel@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo/+/9d35298a6223278a66423f828a949d93d94d5911

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M libjpeg.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fbarchard1
noel, are you able to review? I see you made some of the recent changes ...
4 years, 8 months ago (2016-04-08 23:34:23 UTC) #1
Noel Gordon
Yes, seems fine. LGTM.
4 years, 8 months ago (2016-04-09 00:35:43 UTC) #2
kjellander_chromium
lgtm
4 years, 8 months ago (2016-04-11 18:20:13 UTC) #4
fbarchard1
4 years, 8 months ago (2016-04-11 18:46:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9d35298a6223278a66423f828a949d93d94d5911 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698