Copy the necessary build overrides from Chromium

Copy the necessary build overrides from Chromium

These are the copies of files necessary for GN build, taken from
Chromium src/build_overrides.

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4371
R=mcgrathr@chromium.org

Committed: https://chromium.googlesource.com/native_client/src/build_overrides/+/7858afa5620b83855e381f7399b3494849d1902e

[Petr Hosek, 2016-04-29 22:08:27]

Description was changed from

==========
Copy the necessary build overrides from Chromium

These are the copies of files necessary for GN build, taken from
Chromium src/build_overrides.

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4371
==========

to

==========
Copy the necessary build overrides from Chromium

These are the copies of files necessary for GN build, taken from
Chromium src/build_overrides.

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4371
==========

[Petr Hosek, 2016-04-29 22:08:28]

phosek@chromium.org changed reviewers:
+ mcgrathr@chromium.org

[Petr Hosek, 2016-04-29 22:09:44]

I omitted pdfium.gni, v8.gni and webrtc.gni since these shouldn't be needed for
NaCl build.

[Roland McGrath, 2016-04-29 22:25:12]

LGTM with additional comments added as per below

https://codereview.chromium.org/1934803002/diff/1/build.gni
File build.gni (right):

https://codereview.chromium.org/1934803002/diff/1/build.gni#newcode4
build.gni:4: 
I assume this file is copied verbatim from the chromium version.
There should be some kind of comment somewhere saying explicitly which files
were copied verbatim from where, and making clear that we should be manually
tracking these files in chromium to keep the copies here matching whenever we
update DEPS for build/ et al.  It's probably better to keep the copied file
itself verbatim so it can be updated with a simple cp.  So perhaps add a README
of some sort to the directory.

https://codereview.chromium.org/1934803002/diff/1/gtest.gni
File gtest.gni (right):

https://codereview.chromium.org/1934803002/diff/1/gtest.gni#newcode5
gtest.gni:5: # Exclude support for registering main function in multi-process
tests.
This file should have an overall comment pointing to the chromium version of
this file, so it's clear that one may need to track future additions to that
file and update this file with new/changed variables.

For each of the variables, there should be an explicit comment saying whether it
matches the chromium definition or not.  If not, a specific explanation of why
it needs to differ.

[Petr Hosek, 2016-04-29 22:36:54]

https://codereview.chromium.org/1934803002/diff/1/build.gni
File build.gni (right):

https://codereview.chromium.org/1934803002/diff/1/build.gni#newcode4
build.gni:4: 
On 2016/04/29 22:25:12, Roland McGrath wrote:
> I assume this file is copied verbatim from the chromium version.
> There should be some kind of comment somewhere saying explicitly which files
> were copied verbatim from where, and making clear that we should be manually
> tracking these files in chromium to keep the copies here matching whenever we
> update DEPS for build/ et al.  It's probably better to keep the copied file
> itself verbatim so it can be updated with a simple cp.  So perhaps add a
README
> of some sort to the directory.

Done.

https://codereview.chromium.org/1934803002/diff/1/gtest.gni
File gtest.gni (right):

https://codereview.chromium.org/1934803002/diff/1/gtest.gni#newcode5
gtest.gni:5: # Exclude support for registering main function in multi-process
tests.
On 2016/04/29 22:25:12, Roland McGrath wrote:
> This file should have an overall comment pointing to the chromium version of
> this file, so it's clear that one may need to track future additions to that
> file and update this file with new/changed variables.
> 
> For each of the variables, there should be an explicit comment saying whether
it
> matches the chromium definition or not.  If not, a specific explanation of why
> it needs to differ.

Done.

[Petr Hosek, 2016-04-29 22:41:17]

Description was changed from

==========
Copy the necessary build overrides from Chromium

These are the copies of files necessary for GN build, taken from
Chromium src/build_overrides.

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4371
==========

to

==========
Copy the necessary build overrides from Chromium

These are the copies of files necessary for GN build, taken from
Chromium src/build_overrides.

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4371
R=mcgrathr@chromium.org

Committed:
https://chromium.googlesource.com/native_client/src/build_overrides/+/7858afa...
==========

[Petr Hosek, 2016-04-29 22:41:18]

Committed patchset #3 (id:40001) manually as
7858afa5620b83855e381f7399b3494849d1902e (presubmit successful).