build.gni - Issue 1934803002: Copy the necessary build overrides from Chromium

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build.gni

Issue 1934803002: Copy the necessary build overrides from Chromium (Closed) Base URL: https://chromium.googlesource.com/native_client/src/build_overrides@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4
	Roland McGrath 2016/04/29 22:25:12 I assume this file is copied verbatim from the chr I assume this file is copied verbatim from the chromium version. There should be some kind of comment somewhere saying explicitly which files were copied verbatim from where, and making clear that we should be manually tracking these files in chromium to keep the copies here matching whenever we update DEPS for build/ et al. It's probably better to keep the copied file itself verbatim so it can be updated with a simple cp. So perhaps add a README of some sort to the directory. Petr Hosek 2016/04/29 22:36:54 Done. Show quoted text On 2016/04/29 22:25:12, Roland McGrath wrote: > I assume this file is copied verbatim from the chromium version. > There should be some kind of comment somewhere saying explicitly which files > were copied verbatim from where, and making clear that we should be manually > tracking these files in chromium to keep the copies here matching whenever we > update DEPS for build/ et al. It's probably better to keep the copied file > itself verbatim so it can be updated with a simple cp. So perhaps add a README > of some sort to the directory. Done.
	5 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=5453.

	6 # Some WebRTC targets require the 10.7 deployment version of the Mac SDK

	7 # and a 10.11 min SDK, but those targets are only used in non-Chromium

	8 # builds. We can remove this when Chromium drops 10.6 support and also

	9 # requires 10.7.

	10 mac_sdk_min_build_override = "10.10"

	11 mac_deployment_target_build_override = "10.7"

	12

	13 # Variable that can be used to support multiple build scenarios, like having

	14 # Chromium specific targets in a client project's GN file etc.

	15 build_with_chromium = true

OLD	NEW

« no previous file with comments | « no previous file | codereview.settings » ('j') | gtest.gni » ('J')