gtest.gni - Issue 1934803002: Copy the necessary build overrides from Chromium

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: gtest.gni

Issue 1934803002: Copy the necessary build overrides from Chromium (Closed) Base URL: https://chromium.googlesource.com/native_client/src/build_overrides@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 # Exclude support for registering main function in multi-process tests.
	Roland McGrath 2016/04/29 22:25:12 This file should have an overall comment pointing This file should have an overall comment pointing to the chromium version of this file, so it's clear that one may need to track future additions to that file and update this file with new/changed variables. For each of the variables, there should be an explicit comment saying whether it matches the chromium definition or not. If not, a specific explanation of why it needs to differ. Petr Hosek 2016/04/29 22:36:54 Done. Show quoted text On 2016/04/29 22:25:12, Roland McGrath wrote: > This file should have an overall comment pointing to the chromium version of > this file, so it's clear that one may need to track future additions to that > file and update this file with new/changed variables. > > For each of the variables, there should be an explicit comment saying whether it > matches the chromium definition or not. If not, a specific explanation of why > it needs to differ. Done.
	6 gtest_include_multiprocess = false

	7

	8 # Exclude support for platform-specific operations across unit tests.

	9 gtest_include_platform_test = false

OLD	NEW

« build.gni ('K') | « codereview.settings ('k') | no next file » | no next file with comments »