move colorshader into its own .cpp, add color4f variant

move colorshader into its own .cpp, add color4f variant

Implemented as a different subclass for SkColorShader (which is also private) partly to make the CL clearer/simpler, and partly for flatten/unflatten compatibility. Later I'm sure we could combine these if that proves useful.

Lots of TODOs at the moment, but still valuable to get reviewed.

Note: this ignores the question (for the moment) about how to interpret SkColor in the larger world. That needs to happen, but this CL is more focused on what *else* to do besides handle the old-style input (and old-style pipeline).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1934313002

Committed: https://skia.googlesource.com/skia/+/0ccc62d4f79809fe20de299ba1fabdf2592ce2e5

[reed1, 2016-05-02 14:12:35]

Description was changed from

==========
move colorshader into its own .cpp, add color4f variant

BUG=skia:
==========

to

==========
move colorshader into its own .cpp, add color4f variant

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed1, 2016-05-02 15:23:26]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-02 15:23:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1934313002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1934313002/20001

[reed1, 2016-05-02 15:24:28]

Description was changed from

==========
move colorshader into its own .cpp, add color4f variant

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
move colorshader into its own .cpp, add color4f variant

Implemented as a different subclass for SkColorShader (which is also private)
partly to make the CL clearer/simpler, and partly for flatten/unflatten
compatibility. Later I'm sure we could combine these if that proves useful.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[commit-bot: I haz the power, 2016-05-02 15:24:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-02 15:24:39]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)

[reed1, 2016-05-02 15:24:59]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-02 15:25:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1934313002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1934313002/40001

[reed1, 2016-05-02 15:25:28]

Description was changed from

==========
move colorshader into its own .cpp, add color4f variant

Implemented as a different subclass for SkColorShader (which is also private)
partly to make the CL clearer/simpler, and partly for flatten/unflatten
compatibility. Later I'm sure we could combine these if that proves useful.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
move colorshader into its own .cpp, add color4f variant

Implemented as a different subclass for SkColorShader (which is also private)
partly to make the CL clearer/simpler, and partly for flatten/unflatten
compatibility. Later I'm sure we could combine these if that proves useful.

Lots of TODOs at the moment, but still valuable to get reviewed.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed1, 2016-05-02 15:26:08]

reed@google.com changed reviewers:
+ brianosman@google.com, bsalomon@google.com, fmalita@chromium.org,
msarda@google.com

[reed1, 2016-05-02 15:27:05]

Description was changed from

==========
move colorshader into its own .cpp, add color4f variant

Implemented as a different subclass for SkColorShader (which is also private)
partly to make the CL clearer/simpler, and partly for flatten/unflatten
compatibility. Later I'm sure we could combine these if that proves useful.

Lots of TODOs at the moment, but still valuable to get reviewed.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
move colorshader into its own .cpp, add color4f variant

Implemented as a different subclass for SkColorShader (which is also private)
partly to make the CL clearer/simpler, and partly for flatten/unflatten
compatibility. Later I'm sure we could combine these if that proves useful.

Lots of TODOs at the moment, but still valuable to get reviewed.

Note: this ignores the question (for the moment) about how to interpret SkColor
in the larger world. That needs to happen, but this CL is more focused on what
*else* to do besides handle the old-style input (and old-style pipeline).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed1, 2016-05-02 15:27:47]

reed@google.com changed reviewers:
+ msarett@google.com
- msarda@google.com

[commit-bot: I haz the power, 2016-05-02 15:47:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-02 15:47:02]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-05-02 18:46:07]

lgtm

[reed1, 2016-05-04 19:09:06]

The CQ bit was checked by reed@google.com

[reed1, 2016-05-04 19:09:06]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1934313002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-05-04 19:09:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1934313002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1934313002/80001

[commit-bot: I haz the power, 2016-05-04 19:19:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 19:19:24]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[reed1, 2016-05-04 19:52:57]

The CQ bit was checked by reed@google.com

[reed1, 2016-05-04 19:52:58]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1934313002/#ps100001
(title: "register for serialization, amend GM view for future picture
expansion")

[commit-bot: I haz the power, 2016-05-04 19:53:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1934313002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1934313002/100001

[commit-bot: I haz the power, 2016-05-04 20:09:41]

Description was changed from

==========
move colorshader into its own .cpp, add color4f variant

Implemented as a different subclass for SkColorShader (which is also private)
partly to make the CL clearer/simpler, and partly for flatten/unflatten
compatibility. Later I'm sure we could combine these if that proves useful.

Lots of TODOs at the moment, but still valuable to get reviewed.

Note: this ignores the question (for the moment) about how to interpret SkColor
in the larger world. That needs to happen, but this CL is more focused on what
*else* to do besides handle the old-style input (and old-style pipeline).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
move colorshader into its own .cpp, add color4f variant

Implemented as a different subclass for SkColorShader (which is also private)
partly to make the CL clearer/simpler, and partly for flatten/unflatten
compatibility. Later I'm sure we could combine these if that proves useful.

Lots of TODOs at the moment, but still valuable to get reviewed.

Note: this ignores the question (for the moment) about how to interpret SkColor
in the larger world. That needs to happen, but this CL is more focused on what
*else* to do besides handle the old-style input (and old-style pipeline).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/0ccc62d4f79809fe20de299ba1fabdf2592ce2e5
==========

[commit-bot: I haz the power, 2016-05-04 20:09:42]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/0ccc62d4f79809fe20de299ba1fabdf2592ce2e5