Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1934033002: Revert of Add next_version_mini_installer to MiniInstallerTest's compile targets. (Closed)

Created:
4 years, 7 months ago by Dirk Pranke
Modified:
4 years, 7 months ago
Reviewers:
fdoray
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Add next_version_mini_installer to MiniInstallerTest's compile targets. (patchset #2 id:20001 of https://codereview.chromium.org/1935583002/ ) Reason for revert: Unfortunately, I need to revert this because it breaks one of the internal builders. See the details in crbug.com/608066. Original issue's description: > Add next_version_mini_installer to MiniInstallerTest's compile targets. > > We plan to start using next_version_mini_installer.exe in mini_installer > tests https://codereview.chromium.org/1929383002 > > BUG=605177 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300363 TBR=fdoray@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=605177 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300379

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -79 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/steps.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_skia_Win_Builder.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_skia_Win_Builder_Trybot.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/analyze_runs_nothing_with_no_source_file_changes.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/analyze_webkit.json View 2 chunks +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win10_chromium_x64_rel_ng.json View 2 chunks +5 lines, -10 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win10_chromium_x64_rel_ng_exp.json View 2 chunks +5 lines, -10 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_compile_rel_ng.json View 2 chunks +5 lines, -10 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_rel_ng.json View 2 chunks +5 lines, -10 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_x64_rel_ng.json View 2 chunks +5 lines, -10 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/process_dumps_failure.json View 2 chunks +5 lines, -10 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Dirk Pranke
Created Revert of Add next_version_mini_installer to MiniInstallerTest's compile targets.
4 years, 7 months ago (2016-04-29 23:36:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934033002/1
4 years, 7 months ago (2016-04-29 23:36:15 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-04-29 23:36:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300379

Powered by Google App Engine
This is Rietveld 408576698