scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json - Issue 1934033002: Revert of Add next_version_mini_installer to MiniInstallerTest's compile targets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json

Issue 1934033002: Revert of Add next_version_mini_installer to MiniInstallerTest's compile targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium_trybot.expected/process_dumps_failure.json ('k') | scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json

diff --git a/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json b/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json

index db10ecd0d48a46b19079fce016e600f105be54c8..414f137c2d0ba85a7a9700b667d4b93f20171bc4 100644

--- a/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json

+++ b/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json

@@ -306,7 +306,7 @@

"win_chromium_rel_ng",

"-v",

"//out/Release",

- "{\"additional_compile_targets\": [\"chromium_builder_tests\"], \"files\": [\"foo.cc\"], \"test_targets\": [\"mini_installer\", \"next_version_mini_installer\"]}",

+ "{\"additional_compile_targets\": [\"chromium_builder_tests\"], \"files\": [\"foo.cc\"], \"test_targets\": [\"mini_installer\"]}",

"/path/to/tmp/json"

"env": {

@@ -329,8 +329,7 @@

"@@@STEP_LOG_LINE@analyze_details@ \"self.m.filter.compile_targets\": [], @@@",

"@@@STEP_LOG_LINE@analyze_details@ \"self.m.filter.test_targets\": [], @@@",

"@@@STEP_LOG_LINE@analyze_details@ \"test_targets\": [@@@",

- "@@@STEP_LOG_LINE@analyze_details@ \"mini_installer\", @@@",

- "@@@STEP_LOG_LINE@analyze_details@ \"next_version_mini_installer\"@@@",

+ "@@@STEP_LOG_LINE@analyze_details@ \"mini_installer\"@@@",

"@@@STEP_LOG_LINE@analyze_details@ ]@@@",

"@@@STEP_LOG_LINE@analyze_details@}@@@",

"@@@STEP_LOG_END@analyze_details@@@"