Used oneof in blimp_message.proto

blimp/common/proto/tab_control.proto

Index: blimp/common/proto/tab_control.proto
diff --git a/blimp/common/proto/tab_control.proto b/blimp/common/proto/tab_control.proto
index 53d66ee3a6406f3c63e0dd8049a8a94b5a7ee87d..9bd95a833e5dca227b471fa907c220ccd98fb385 100644
--- a/blimp/common/proto/tab_control.proto
+++ b/blimp/common/proto/tab_control.proto
@@ -33,8 +33,5 @@ message TabControlMessage {
   optional Type type = 1;
 
   // Feature-specific messages follow.
-  // Only one of these fields may be set per TabControlMessage.
-  // TODO(kmarshall): use a 'oneof' union when it's supported in Chromium.  See
-  // crbug.com/570371.

[Wez, 2016/05/18 01:53:31]

Why are we removing this comment, since this proto still doesn't use oneof yet?

[shaktisahu, 2016/05/18 03:55:42]

There is only one field here. Do we still need a oneof? 

[Wez, 2016/05/20 21:10:49]

Good question; I'd suggest that we have some sort of EmptyMessage, with no
fields, and have something like:

oneof {
  EmptyMessage create_tab
  EmptyMessage close_tab
  SizeMessage size
}

since there are actually three control messages in here, it's just that two of
them have no parameters!

[shaktisahu, 2016/05/20 22:29:41]

Done.

   optional SizeMessage size = 1000;
 }