Used oneof in blimp_message.proto

blimp/engine/feature/engine_settings_feature.cc

Index: blimp/engine/feature/engine_settings_feature.cc
diff --git a/blimp/engine/feature/engine_settings_feature.cc b/blimp/engine/feature/engine_settings_feature.cc
index 65572c567cc3b275cfb31f31293bc4e517db8727..520d165580b654906e68a3ddfd421668883669d2 100644
--- a/blimp/engine/feature/engine_settings_feature.cc
+++ b/blimp/engine/feature/engine_settings_feature.cc
@@ -25,8 +25,7 @@ EngineSettingsFeature::~EngineSettingsFeature() {}
 void EngineSettingsFeature::ProcessMessage(
     std::unique_ptr<BlimpMessage> message,
     const net::CompletionCallback& callback) {
-  DCHECK_EQ(message->type(), BlimpMessage::SETTINGS);
-  DCHECK(message->has_settings());
+  DCHECK_EQ(BlimpMessage::kSettings, message->feature_case());

[Wez, 2016/05/18 01:53:31]

nit: DCHECK(has_settings())

[shaktisahu, 2016/05/18 03:55:42]

As we discussed, it is better to keep the DCHECK_EQ since it provides extra
information.

 
   const SettingsMessage& settings = message->settings();
   DCHECK(settings.has_engine_settings());