blimp/common/proto/tab_control.proto - Issue 1933053003: Used oneof in blimp_message.proto

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/common/proto/tab_control.proto

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Kevin's comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« blimp/common/proto/blimp_message.proto ('K') | « blimp/common/proto/blimp_message.proto ('k') | blimp/engine/feature/engine_render_widget_feature.cc » ('j') | blimp/engine/feature/engine_settings_feature.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4 //	4 //

5 // Message definitions for browser tab control messages.	5 // Message definitions for browser tab control messages.

6	6

7 syntax = "proto2";	7 syntax = "proto2";

8	8

9 option optimize_for = LITE_RUNTIME;	9 option optimize_for = LITE_RUNTIME;

10	10

(...skipping 15 matching lines...) Expand all Loading...
26 CREATE_TAB = 1;	26 CREATE_TAB = 1;

27 CLOSE_TAB = 2;	27 CLOSE_TAB = 2;

28	28

29 // Client => Server types.	29 // Client => Server types.

30 SIZE = 3;	30 SIZE = 3;

31 }	31 }

32	32

33 optional Type type = 1;	33 optional Type type = 1;

34	34

35 // Feature-specific messages follow.	35 // Feature-specific messages follow.

36 // Only one of these fields may be set per TabControlMessage.

37 // TODO(kmarshall): use a 'oneof' union when it's supported in Chromium. See

38 // crbug.com/570371.
Wez 2016/05/18 01:53:31 Why are we removing this comment, since this proto Why are we removing this comment, since this proto still doesn't use oneof yet? shaktisahu 2016/05/18 03:55:42 There is only one field here. Do we still need a o Show quoted text On 2016/05/18 01:53:31, Wez wrote: > Why are we removing this comment, since this proto still doesn't use oneof yet? There is only one field here. Do we still need a oneof? Wez 2016/05/20 21:10:49 Good question; I'd suggest that we have some sort Show quoted text On 2016/05/18 03:55:42, shaktisahu wrote: > On 2016/05/18 01:53:31, Wez wrote: > > Why are we removing this comment, since this proto still doesn't use oneof > yet? > > There is only one field here. Do we still need a oneof? Good question; I'd suggest that we have some sort of EmptyMessage, with no fields, and have something like: oneof { EmptyMessage create_tab EmptyMessage close_tab SizeMessage size } since there are actually three control messages in here, it's just that two of them have no parameters! shaktisahu 2016/05/20 22:29:41 Done. Show quoted text On 2016/05/20 21:10:49, Wez wrote: > On 2016/05/18 03:55:42, shaktisahu wrote: > > On 2016/05/18 01:53:31, Wez wrote: > > > Why are we removing this comment, since this proto still doesn't use oneof > > yet? > > > > There is only one field here. Do we still need a oneof? > > Good question; I'd suggest that we have some sort of EmptyMessage, with no > fields, and have something like: > > oneof { > EmptyMessage create_tab > EmptyMessage close_tab > SizeMessage size > } > > since there are actually three control messages in here, it's just that two of > them have no parameters! Done.
39 optional SizeMessage size = 1000;	36 optional SizeMessage size = 1000;

40 }	37 }

OLD	NEW