Used oneof in blimp_message.proto

blimp/common/create_blimp_message.cc

Index: blimp/common/create_blimp_message.cc
diff --git a/blimp/common/create_blimp_message.cc b/blimp/common/create_blimp_message.cc
index 43d4377803623c65b5afcbb09a33391869ff370b..216e86295badcb0cf6260d1bd600dabe8a903247 100644
--- a/blimp/common/create_blimp_message.cc
+++ b/blimp/common/create_blimp_message.cc
@@ -21,7 +21,6 @@ std::unique_ptr<BlimpMessage> CreateBlimpMessage(
     int target_tab_id) {
   DCHECK(compositor_message);

[Wez, 2016/05/18 01:53:31]

nit: While you're here, can we remove these DCHECKs, please, since these
functions will crash when we try to assign to *foo_message if foo_message is
null?

[shaktisahu, 2016/05/18 03:55:42]

Done.

   std::unique_ptr<BlimpMessage> output(new BlimpMessage);
-  output->set_type(BlimpMessage::COMPOSITOR);
   output->set_target_tab_id(target_tab_id);
   *compositor_message = output->mutable_compositor();
   return output;
@@ -31,7 +30,6 @@ std::unique_ptr<BlimpMessage> CreateBlimpMessage(
     TabControlMessage** control_message) {
   DCHECK(control_message);
   std::unique_ptr<BlimpMessage> output(new BlimpMessage);
-  output->set_type(BlimpMessage::TAB_CONTROL);
   *control_message = output->mutable_tab_control();
   return output;
 }
@@ -39,7 +37,6 @@ std::unique_ptr<BlimpMessage> CreateBlimpMessage(
 std::unique_ptr<BlimpMessage> CreateBlimpMessage(InputMessage** input_message) {
   DCHECK(input_message);
   std::unique_ptr<BlimpMessage> output(new BlimpMessage);
-  output->set_type(BlimpMessage::INPUT);
   *input_message = output->mutable_input();
   return output;
 }
@@ -49,7 +46,6 @@ std::unique_ptr<BlimpMessage> CreateBlimpMessage(
     int target_tab_id) {
   DCHECK(navigation_message);
   std::unique_ptr<BlimpMessage> output(new BlimpMessage);
-  output->set_type(BlimpMessage::NAVIGATION);
   output->set_target_tab_id(target_tab_id);
   *navigation_message = output->mutable_navigation();
   return output;
@@ -59,7 +55,6 @@ std::unique_ptr<BlimpMessage> CreateBlimpMessage(ImeMessage** ime_message,
                                                  int target_tab_id) {
   DCHECK(ime_message);
   std::unique_ptr<BlimpMessage> output(new BlimpMessage);
-  output->set_type(BlimpMessage::IME);
   output->set_target_tab_id(target_tab_id);
   *ime_message = output->mutable_ime();
   return output;
@@ -70,7 +65,6 @@ std::unique_ptr<BlimpMessage> CreateBlimpMessage(
     int target_tab_id) {
   DCHECK(render_widget_message);
   std::unique_ptr<BlimpMessage> output(new BlimpMessage);
-  output->set_type(BlimpMessage::RENDER_WIDGET);
   output->set_target_tab_id(target_tab_id);
   *render_widget_message = output->mutable_render_widget();
   return output;
@@ -89,7 +83,6 @@ std::unique_ptr<BlimpMessage> CreateBlimpMessage(
     EngineSettingsMessage** engine_settings) {
   DCHECK(engine_settings);
   std::unique_ptr<BlimpMessage> output(new BlimpMessage);
-  output->set_type(BlimpMessage::SETTINGS);
   *engine_settings = output->mutable_settings()->mutable_engine_settings();
   return output;
 }
@@ -98,7 +91,6 @@ std::unique_ptr<BlimpMessage> CreateStartConnectionMessage(
     const std::string& client_token,
     int protocol_version) {
   std::unique_ptr<BlimpMessage> output(new BlimpMessage);
-  output->set_type(BlimpMessage::PROTOCOL_CONTROL);
 
   ProtocolControlMessage* control_message = output->mutable_protocol_control();
   control_message->set_type(ProtocolControlMessage::START_CONNECTION);
@@ -114,7 +106,6 @@ std::unique_ptr<BlimpMessage> CreateStartConnectionMessage(
 std::unique_ptr<BlimpMessage> CreateCheckpointAckMessage(
     int64_t checkpoint_id) {
   std::unique_ptr<BlimpMessage> output(new BlimpMessage);
-  output->set_type(BlimpMessage::PROTOCOL_CONTROL);
 
   ProtocolControlMessage* control_message = output->mutable_protocol_control();
   control_message->set_type(ProtocolControlMessage::CHECKPOINT_ACK);