Used oneof in blimp_message.proto

blimp/client/feature/render_widget_feature.cc

Index: blimp/client/feature/render_widget_feature.cc
diff --git a/blimp/client/feature/render_widget_feature.cc b/blimp/client/feature/render_widget_feature.cc
index e92258de2002cdd2a227f99c7ae0ee1ebd2dcc32..6936e7d36134a67938e6a46d363ff3b26606a0ee 100644
--- a/blimp/client/feature/render_widget_feature.cc
+++ b/blimp/client/feature/render_widget_feature.cc
@@ -83,19 +83,19 @@ void RenderWidgetFeature::ProcessMessage(
     std::unique_ptr<BlimpMessage> message,
     const net::CompletionCallback& callback) {
   DCHECK(!callback.is_null());
-  DCHECK(message->type() == BlimpMessage::RENDER_WIDGET ||
-         message->type() == BlimpMessage::COMPOSITOR);
+  DCHECK(BlimpMessage::kRenderWidget == message->feature_case() ||
+         BlimpMessage::kCompositor == message->feature_case());

[Wez, 2016/05/18 01:53:31]

Suggest DCHECK(has_render_widget() || has_compositor()) here.

[shaktisahu, 2016/05/18 03:55:42]

ditto

 
   int target_tab_id = message->target_tab_id();
   RenderWidgetFeatureDelegate* delegate = FindDelegate(target_tab_id);
   DCHECK(delegate) << "RenderWidgetFeatureDelegate not found for "
       << target_tab_id;
 
-  switch (message->type()) {
-    case BlimpMessage::RENDER_WIDGET:
+  switch (message->feature_case()) {
+    case BlimpMessage::kRenderWidget:
       ProcessRenderWidgetMessage(delegate, message->render_widget());
       break;
-    case BlimpMessage::COMPOSITOR:
+    case BlimpMessage::kCompositor:
       ProcessCompositorMessage(delegate, message->compositor());
       break;
     default: