blimp/common/create_blimp_message_unittest.cc - Issue 1933053003: Used oneof in blimp_message.proto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/common/create_blimp_message_unittest.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Kevin's comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/common/create_blimp_message_unittest.cc

diff --git a/blimp/common/create_blimp_message_unittest.cc b/blimp/common/create_blimp_message_unittest.cc

index d2b57dc5488ad63b68cb4830e1867dd8735a1174..09870ee9a1173df358b0749f5773bb8a6e6e9800 100644

--- a/blimp/common/create_blimp_message_unittest.cc

+++ b/blimp/common/create_blimp_message_unittest.cc

@@ -82,7 +82,7 @@ TEST(CreateBlimpMessageTest, StartConnectionMessage) {

std::unique_ptr<BlimpMessage> message =

CreateStartConnectionMessage(client_token, protocol_version);

EXPECT_NE(nullptr, message);

- EXPECT_EQ(BlimpMessage::PROTOCOL_CONTROL, message->type());

+ EXPECT_EQ(BlimpMessage::kProtocolControl, message->feature_case());

EXPECT_EQ(ProtocolControlMessage::START_CONNECTION,

message->protocol_control().type());

EXPECT_EQ(client_token,