blimp/client/feature/navigation_feature.cc - Issue 1933053003: Used oneof in blimp_message.proto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/feature/navigation_feature.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Kevin's comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/feature/navigation_feature.cc

diff --git a/blimp/client/feature/navigation_feature.cc b/blimp/client/feature/navigation_feature.cc

index 34922363c31c9f7ba0b82d393e55fdf79b318457..9902230bc2f109e9f08bac2299276fe33196da8b 100644

--- a/blimp/client/feature/navigation_feature.cc

+++ b/blimp/client/feature/navigation_feature.cc

@@ -102,10 +102,9 @@ void NavigationFeature::ProcessMessage(

std::unique_ptr<BlimpMessage> message,

const net::CompletionCallback& callback) {

DCHECK(!callback.is_null());

- DCHECK(message->type() == BlimpMessage::NAVIGATION);

+ DCHECK_EQ(BlimpMessage::kNavigation, message->feature_case());

int tab_id = message->target_tab_id();

- DCHECK(message->has_navigation());

const NavigationMessage& navigation_message = message->navigation();

NavigationFeatureDelegate* delegate = FindDelegate(tab_id);