Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2952)

Unified Diff: blimp/common/proto/tab_control.proto

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/common/proto/protocol_control.proto ('k') | blimp/engine/feature/engine_render_widget_feature.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/common/proto/tab_control.proto
diff --git a/blimp/common/proto/tab_control.proto b/blimp/common/proto/tab_control.proto
index 53d66ee3a6406f3c63e0dd8049a8a94b5a7ee87d..b36631b71ce8a65a341c2e8349880906c53847f1 100644
--- a/blimp/common/proto/tab_control.proto
+++ b/blimp/common/proto/tab_control.proto
@@ -18,23 +18,16 @@ message SizeMessage {
optional float device_pixel_ratio = 3;
}
-message TabControlMessage {
- enum Type {
- UNKNOWN = 0;
+message EmptyMessage {}
+message TabControlMessage {
+ // Feature-specific messages follow.
+ oneof tab_control {
// Client <=> Server types.
- CREATE_TAB = 1;
- CLOSE_TAB = 2;
+ EmptyMessage create_tab = 40;
+ EmptyMessage close_tab = 41;
// Client => Server types.
- SIZE = 3;
+ SizeMessage size = 42;
}
-
- optional Type type = 1;
-
- // Feature-specific messages follow.
- // Only one of these fields may be set per TabControlMessage.
- // TODO(kmarshall): use a 'oneof' union when it's supported in Chromium. See
- // crbug.com/570371.
- optional SizeMessage size = 1000;
}
« no previous file with comments | « blimp/common/proto/protocol_control.proto ('k') | blimp/engine/feature/engine_render_widget_feature.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698