Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2112)

Unified Diff: blimp/common/proto/protocol_control.proto

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/common/proto/blimp_message.proto ('k') | blimp/common/proto/tab_control.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/common/proto/protocol_control.proto
diff --git a/blimp/common/proto/protocol_control.proto b/blimp/common/proto/protocol_control.proto
index 7dd1004490270137fa3ead2a340092cf8658cc8c..3e743a800b19a84e24db837ad537102e314460c7 100644
--- a/blimp/common/proto/protocol_control.proto
+++ b/blimp/common/proto/protocol_control.proto
@@ -20,20 +20,11 @@ message StartConnectionMessage {
}
message ProtocolControlMessage {
- enum Type {
- UNKNOWN = 0;
-
+ oneof connection_message {
// Client => Server types.
- START_CONNECTION = 1;
-
- // Server => Client types will start from 100.
+ StartConnectionMessage start_connection = 41;
- // Bi-directional types.
- CHECKPOINT_ACK = 200;
+ // Server => Client types.
+ CheckpointAckMessage checkpoint_ack = 42;
}
-
- optional Type type = 1;
-
- optional StartConnectionMessage start_connection = 1001;
- optional CheckpointAckMessage checkpoint_ack = 1200;
}
« no previous file with comments | « blimp/common/proto/blimp_message.proto ('k') | blimp/common/proto/tab_control.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698