Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1216)

Unified Diff: blimp/engine/feature/engine_render_widget_feature.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/common/proto/tab_control.proto ('k') | blimp/engine/feature/engine_render_widget_feature_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/engine/feature/engine_render_widget_feature.cc
diff --git a/blimp/engine/feature/engine_render_widget_feature.cc b/blimp/engine/feature/engine_render_widget_feature.cc
index 37688c3e4d96987acd17d74ac693429b5bcab9ce..fccb811d2a62988b8a5bed826622bdf92535fb34 100644
--- a/blimp/engine/feature/engine_render_widget_feature.cc
+++ b/blimp/engine/feature/engine_render_widget_feature.cc
@@ -190,10 +190,10 @@ void EngineRenderWidgetFeature::ProcessMessage(
std::unique_ptr<BlimpMessage> message,
const net::CompletionCallback& callback) {
DCHECK(!callback.is_null());
- DCHECK(message->type() == BlimpMessage::RENDER_WIDGET ||
- message->type() == BlimpMessage::IME ||
- message->type() == BlimpMessage::INPUT ||
- message->type() == BlimpMessage::COMPOSITOR);
+ DCHECK(message->feature_case() == BlimpMessage::kRenderWidget ||
+ message->feature_case() == BlimpMessage::kIme ||
+ message->feature_case() == BlimpMessage::kInput ||
+ message->feature_case() == BlimpMessage::kCompositor);
int target_tab_id = message->target_tab_id();
@@ -202,8 +202,8 @@ void EngineRenderWidgetFeature::ProcessMessage(
content::RenderWidgetHost* render_widget_host = nullptr;
- switch (message->type()) {
- case BlimpMessage::INPUT:
+ switch (message->feature_case()) {
+ case BlimpMessage::kInput:
render_widget_host = GetRenderWidgetHost(target_tab_id,
message->input().render_widget_id());
if (render_widget_host) {
@@ -213,7 +213,7 @@ void EngineRenderWidgetFeature::ProcessMessage(
delegate->OnWebGestureEvent(render_widget_host, std::move(event));
}
break;
- case BlimpMessage::COMPOSITOR:
+ case BlimpMessage::kCompositor:
render_widget_host = GetRenderWidgetHost(target_tab_id,
message->compositor().render_widget_id());
if (render_widget_host) {
@@ -224,7 +224,7 @@ void EngineRenderWidgetFeature::ProcessMessage(
delegate->OnCompositorMessageReceived(render_widget_host, payload);
}
break;
- case BlimpMessage::IME:
+ case BlimpMessage::kIme:
DCHECK(message->ime().type() == ImeMessage::SET_TEXT);
render_widget_host =
GetRenderWidgetHost(target_tab_id, message->ime().render_widget_id());
« no previous file with comments | « blimp/common/proto/tab_control.proto ('k') | blimp/engine/feature/engine_render_widget_feature_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698