Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2735)

Unified Diff: blimp/common/create_blimp_message_unittest.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/common/create_blimp_message.cc ('k') | blimp/common/logging.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/common/create_blimp_message_unittest.cc
diff --git a/blimp/common/create_blimp_message_unittest.cc b/blimp/common/create_blimp_message_unittest.cc
index d2b57dc5488ad63b68cb4830e1867dd8735a1174..063eed58aadbc90889a28a89508e579f9a5f6b9b 100644
--- a/blimp/common/create_blimp_message_unittest.cc
+++ b/blimp/common/create_blimp_message_unittest.cc
@@ -64,7 +64,8 @@ TEST(CreateBlimpMessageTest, SizeMessage) {
std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&details);
EXPECT_NE(nullptr, details);
EXPECT_NE(nullptr, message);
- EXPECT_EQ(TabControlMessage::SIZE, message->mutable_tab_control()->type());
+ EXPECT_EQ(TabControlMessage::kSize,
+ message->mutable_tab_control()->tab_control_case());
EXPECT_EQ(details, message->mutable_tab_control()->mutable_size());
}
@@ -82,9 +83,9 @@ TEST(CreateBlimpMessageTest, StartConnectionMessage) {
std::unique_ptr<BlimpMessage> message =
CreateStartConnectionMessage(client_token, protocol_version);
EXPECT_NE(nullptr, message);
- EXPECT_EQ(BlimpMessage::PROTOCOL_CONTROL, message->type());
- EXPECT_EQ(ProtocolControlMessage::START_CONNECTION,
- message->protocol_control().type());
+ EXPECT_EQ(BlimpMessage::kProtocolControl, message->feature_case());
+ EXPECT_EQ(ProtocolControlMessage::kStartConnection,
+ message->protocol_control().connection_message_case());
EXPECT_EQ(client_token,
message->protocol_control().start_connection().client_token());
EXPECT_EQ(protocol_version,
« no previous file with comments | « blimp/common/create_blimp_message.cc ('k') | blimp/common/logging.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698