Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: blimp/common/create_blimp_message_unittest.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « blimp/common/create_blimp_message.cc ('k') | blimp/common/logging.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "blimp/common/create_blimp_message.h" 5 #include "blimp/common/create_blimp_message.h"
6 #include "blimp/common/proto/blimp_message.pb.h" 6 #include "blimp/common/proto/blimp_message.pb.h"
7 #include "blimp/common/proto/compositor.pb.h" 7 #include "blimp/common/proto/compositor.pb.h"
8 #include "blimp/common/proto/input.pb.h" 8 #include "blimp/common/proto/input.pb.h"
9 #include "blimp/common/proto/navigation.pb.h" 9 #include "blimp/common/proto/navigation.pb.h"
10 #include "blimp/common/proto/render_widget.pb.h" 10 #include "blimp/common/proto/render_widget.pb.h"
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 EXPECT_NE(nullptr, message); 57 EXPECT_NE(nullptr, message);
58 EXPECT_EQ(details, message->mutable_render_widget()); 58 EXPECT_EQ(details, message->mutable_render_widget());
59 EXPECT_EQ(kTabId, message->target_tab_id()); 59 EXPECT_EQ(kTabId, message->target_tab_id());
60 } 60 }
61 61
62 TEST(CreateBlimpMessageTest, SizeMessage) { 62 TEST(CreateBlimpMessageTest, SizeMessage) {
63 SizeMessage* details = nullptr; 63 SizeMessage* details = nullptr;
64 std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&details); 64 std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&details);
65 EXPECT_NE(nullptr, details); 65 EXPECT_NE(nullptr, details);
66 EXPECT_NE(nullptr, message); 66 EXPECT_NE(nullptr, message);
67 EXPECT_EQ(TabControlMessage::SIZE, message->mutable_tab_control()->type()); 67 EXPECT_EQ(TabControlMessage::kSize,
68 message->mutable_tab_control()->tab_control_case());
68 EXPECT_EQ(details, message->mutable_tab_control()->mutable_size()); 69 EXPECT_EQ(details, message->mutable_tab_control()->mutable_size());
69 } 70 }
70 71
71 TEST(CreateBlimpMessageTest, EngineSettingsMessage) { 72 TEST(CreateBlimpMessageTest, EngineSettingsMessage) {
72 EngineSettingsMessage* details; 73 EngineSettingsMessage* details;
73 std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&details); 74 std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&details);
74 EXPECT_NE(nullptr, details); 75 EXPECT_NE(nullptr, details);
75 EXPECT_NE(nullptr, message); 76 EXPECT_NE(nullptr, message);
76 EXPECT_EQ(details, message->mutable_settings()->mutable_engine_settings()); 77 EXPECT_EQ(details, message->mutable_settings()->mutable_engine_settings());
77 } 78 }
78 79
79 TEST(CreateBlimpMessageTest, StartConnectionMessage) { 80 TEST(CreateBlimpMessageTest, StartConnectionMessage) {
80 const char* client_token = "token"; 81 const char* client_token = "token";
81 const int protocol_version = 1; 82 const int protocol_version = 1;
82 std::unique_ptr<BlimpMessage> message = 83 std::unique_ptr<BlimpMessage> message =
83 CreateStartConnectionMessage(client_token, protocol_version); 84 CreateStartConnectionMessage(client_token, protocol_version);
84 EXPECT_NE(nullptr, message); 85 EXPECT_NE(nullptr, message);
85 EXPECT_EQ(BlimpMessage::PROTOCOL_CONTROL, message->type()); 86 EXPECT_EQ(BlimpMessage::kProtocolControl, message->feature_case());
86 EXPECT_EQ(ProtocolControlMessage::START_CONNECTION, 87 EXPECT_EQ(ProtocolControlMessage::kStartConnection,
87 message->protocol_control().type()); 88 message->protocol_control().connection_message_case());
88 EXPECT_EQ(client_token, 89 EXPECT_EQ(client_token,
89 message->protocol_control().start_connection().client_token()); 90 message->protocol_control().start_connection().client_token());
90 EXPECT_EQ(protocol_version, 91 EXPECT_EQ(protocol_version,
91 message->protocol_control().start_connection().protocol_version()); 92 message->protocol_control().start_connection().protocol_version());
92 } 93 }
93 94
94 } // namespace 95 } // namespace
95 } // namespace blimp 96 } // namespace blimp
OLDNEW
« no previous file with comments | « blimp/common/create_blimp_message.cc ('k') | blimp/common/logging.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698