Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: blimp/common/logging.h

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/common/create_blimp_message_unittest.cc ('k') | blimp/common/logging.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/common/logging.h
diff --git a/blimp/common/logging.h b/blimp/common/logging.h
index e53f333e7a3e7d71cc8177590a34de859cdf145a..05fac3cd238d89a355845ba20be5e3425a3d9e93 100644
--- a/blimp/common/logging.h
+++ b/blimp/common/logging.h
@@ -44,15 +44,16 @@ class BLIMP_COMMON_EXPORT BlimpMessageLogger {
void LogMessageToStream(const BlimpMessage& message, std::ostream* out) const;
private:
- // Adds |extractor| to the registry for parsing messages of type |type|.
- // |type_name|: The human readable name of |type|.
- void AddHandler(const std::string& type_name,
- BlimpMessage::Type type,
+ // Adds |extractor| to the registry for parsing messages of type
+ // |feature_case|.
+ // |feature_name|: The human readable name of |feature_case|.
+ void AddHandler(const std::string& feature_name,
+ BlimpMessage::FeatureCase feature_case,
std::unique_ptr<LogExtractor> extractor);
// Registry of log extractors. Map structure is:
// {message type => (human readable message type, LogExtractor*)}
- std::map<BlimpMessage::Type,
+ std::map<BlimpMessage::FeatureCase,
std::pair<std::string, std::unique_ptr<LogExtractor>>>
extractors_;
« no previous file with comments | « blimp/common/create_blimp_message_unittest.cc ('k') | blimp/common/logging.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698