Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2938)

Unified Diff: blimp/client/feature/tab_control_feature.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/client/feature/render_widget_feature.cc ('k') | blimp/client/feature/tab_control_feature_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/feature/tab_control_feature.cc
diff --git a/blimp/client/feature/tab_control_feature.cc b/blimp/client/feature/tab_control_feature.cc
index 25f61a9ad29f2fec05a6ff8010d941e4d96d295c..285d525e4709c5aaa0874f3b68a2ee48a8b452ff 100644
--- a/blimp/client/feature/tab_control_feature.cc
+++ b/blimp/client/feature/tab_control_feature.cc
@@ -46,7 +46,7 @@ void TabControlFeature::SetSizeAndScale(const gfx::Size& size,
void TabControlFeature::CreateTab(int tab_id) {
TabControlMessage* tab_control;
std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&tab_control);
- tab_control->set_type(TabControlMessage::CREATE_TAB);
+ tab_control->mutable_create_tab();
outgoing_message_processor_->ProcessMessage(std::move(message),
net::CompletionCallback());
}
@@ -54,7 +54,7 @@ void TabControlFeature::CreateTab(int tab_id) {
void TabControlFeature::CloseTab(int tab_id) {
TabControlMessage* tab_control;
std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&tab_control);
- tab_control->set_type(TabControlMessage::CLOSE_TAB);
+ tab_control->mutable_close_tab();
outgoing_message_processor_->ProcessMessage(std::move(message),
net::CompletionCallback());
}
« no previous file with comments | « blimp/client/feature/render_widget_feature.cc ('k') | blimp/client/feature/tab_control_feature_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698