Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Side by Side Diff: blimp/client/feature/tab_control_feature.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "blimp/client/feature/tab_control_feature.h" 5 #include "blimp/client/feature/tab_control_feature.h"
6 6
7 #include "blimp/common/create_blimp_message.h" 7 #include "blimp/common/create_blimp_message.h"
8 #include "blimp/common/proto/blimp_message.pb.h" 8 #include "blimp/common/proto/blimp_message.pb.h"
9 #include "blimp/common/proto/tab_control.pb.h" 9 #include "blimp/common/proto/tab_control.pb.h"
10 #include "blimp/net/blimp_message_processor.h" 10 #include "blimp/net/blimp_message_processor.h"
(...skipping 28 matching lines...) Expand all
39 39
40 // TODO(dtrainor): Don't keep sending size events to the server. Wait for a 40 // TODO(dtrainor): Don't keep sending size events to the server. Wait for a
41 // CompletionCallback to return before sending future size updates. 41 // CompletionCallback to return before sending future size updates.
42 outgoing_message_processor_->ProcessMessage(std::move(message), 42 outgoing_message_processor_->ProcessMessage(std::move(message),
43 net::CompletionCallback()); 43 net::CompletionCallback());
44 } 44 }
45 45
46 void TabControlFeature::CreateTab(int tab_id) { 46 void TabControlFeature::CreateTab(int tab_id) {
47 TabControlMessage* tab_control; 47 TabControlMessage* tab_control;
48 std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&tab_control); 48 std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&tab_control);
49 tab_control->set_type(TabControlMessage::CREATE_TAB); 49 tab_control->mutable_create_tab();
50 outgoing_message_processor_->ProcessMessage(std::move(message), 50 outgoing_message_processor_->ProcessMessage(std::move(message),
51 net::CompletionCallback()); 51 net::CompletionCallback());
52 } 52 }
53 53
54 void TabControlFeature::CloseTab(int tab_id) { 54 void TabControlFeature::CloseTab(int tab_id) {
55 TabControlMessage* tab_control; 55 TabControlMessage* tab_control;
56 std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&tab_control); 56 std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&tab_control);
57 tab_control->set_type(TabControlMessage::CLOSE_TAB); 57 tab_control->mutable_close_tab();
58 outgoing_message_processor_->ProcessMessage(std::move(message), 58 outgoing_message_processor_->ProcessMessage(std::move(message),
59 net::CompletionCallback()); 59 net::CompletionCallback());
60 } 60 }
61 61
62 void TabControlFeature::ProcessMessage( 62 void TabControlFeature::ProcessMessage(
63 std::unique_ptr<BlimpMessage> message, 63 std::unique_ptr<BlimpMessage> message,
64 const net::CompletionCallback& callback) { 64 const net::CompletionCallback& callback) {
65 DCHECK(!callback.is_null()); 65 DCHECK(!callback.is_null());
66 callback.Run(net::OK); 66 callback.Run(net::OK);
67 67
68 NOTIMPLEMENTED(); 68 NOTIMPLEMENTED();
69 } 69 }
70 70
71 } // namespace client 71 } // namespace client
72 } // namespace blimp 72 } // namespace blimp
OLDNEW
« no previous file with comments | « blimp/client/feature/render_widget_feature.cc ('k') | blimp/client/feature/tab_control_feature_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698