blimp/client/feature/tab_control_feature_unittest.cc - Issue 1933053003: Used oneof in blimp_message.proto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/feature/tab_control_feature_unittest.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/feature/tab_control_feature_unittest.cc

diff --git a/blimp/client/feature/tab_control_feature_unittest.cc b/blimp/client/feature/tab_control_feature_unittest.cc

index 701346d8cf6b216ae09177afd4baea81bf138a4e..471719e3253390b798e3ac018d2db0c402095acf 100644

--- a/blimp/client/feature/tab_control_feature_unittest.cc

+++ b/blimp/client/feature/tab_control_feature_unittest.cc

@@ -22,7 +22,7 @@ namespace blimp {

namespace client {

MATCHER_P3(EqualsSizeMessage, width, height, dp_to_px, "") {

- return arg.tab_control().type() == TabControlMessage::SIZE &&

+ return arg.tab_control().tab_control_case() == TabControlMessage::kSize &&

arg.tab_control().size().width() == width &&

arg.tab_control().size().height() == height &&

arg.tab_control().size().device_pixel_ratio() == dp_to_px;