Used oneof in blimp_message.proto

blimp/common/logging.cc

Index: blimp/common/logging.cc
diff --git a/blimp/common/logging.cc b/blimp/common/logging.cc
index 6f5587b20843d6e1e5ebb98c77a8b7b944421679..dc791558bf34cb39de9c53ead99b3b400163e63a 100644
--- a/blimp/common/logging.cc
+++ b/blimp/common/logging.cc
@@ -257,26 +257,26 @@ class NullLogExtractor : public LogExtractor {
 }  // namespace
 
 BlimpMessageLogger::BlimpMessageLogger() {
-  AddHandler("COMPOSITOR", BlimpMessage::COMPOSITOR,
+  AddHandler("COMPOSITOR", BlimpMessage::kCompositor,
              base::WrapUnique(new CompositorLogExtractor));
-  AddHandler("INPUT", BlimpMessage::INPUT,
+  AddHandler("INPUT", BlimpMessage::kInput,
              base::WrapUnique(new InputLogExtractor));
-  AddHandler("NAVIGATION", BlimpMessage::NAVIGATION,
+  AddHandler("NAVIGATION", BlimpMessage::kNavigation,
              base::WrapUnique(new NavigationLogExtractor));
-  AddHandler("PROTOCOL_CONTROL", BlimpMessage::PROTOCOL_CONTROL,
+  AddHandler("PROTOCOL_CONTROL", BlimpMessage::kProtocolControl,
              base::WrapUnique(new ProtocolControlLogExtractor));
-  AddHandler("RENDER_WIDGET", BlimpMessage::RENDER_WIDGET,
+  AddHandler("RENDER_WIDGET", BlimpMessage::kRenderWidget,
              base::WrapUnique(new RenderWidgetLogExtractor));
-  AddHandler("SETTINGS", BlimpMessage::SETTINGS,
+  AddHandler("SETTINGS", BlimpMessage::kSettings,
              base::WrapUnique(new SettingsLogExtractor));
-  AddHandler("TAB_CONTROL", BlimpMessage::TAB_CONTROL,
+  AddHandler("TAB_CONTROL", BlimpMessage::kTabControl,
              base::WrapUnique(new TabControlLogExtractor));
 }
 
 BlimpMessageLogger::~BlimpMessageLogger() {}
 
 void BlimpMessageLogger::AddHandler(const std::string& type_name,
-                                    BlimpMessage::Type type,
+                                    BlimpMessage::FeatureCase type,

[Kevin M, 2016/05/02 17:47:48]

I'm no naming savant but it seems like a mishmash to have a "case" called
"type". We might want to switch away from the "type" parameter name in favor of
something else? feature_case...? 

[shaktisahu, 2016/05/16 20:19:02]

hmm.. I am open for suggestions. ++wez@
By the way, the 'Case' suffix of FeatureCase was automatically added by the
proto complier to the union name which I named as 'feature'. We can rename
'feature', but cant rid of 'case'

                                     std::unique_ptr<LogExtractor> extractor) {
   DCHECK(extractors_.find(type) == extractors_.end());
   DCHECK(!type_name.empty());
@@ -287,7 +287,7 @@ void BlimpMessageLogger::LogMessageToStream(const BlimpMessage& message,
                                             std::ostream* out) const {
   LogFields fields;
 
-  auto extractor = extractors_.find(message.type());
+  auto extractor = extractors_.find(message.feature_case());
   if (extractor != extractors_.end()) {
     // An extractor is registered for |message|.
     // Add the human-readable name of |message.type|.
@@ -296,7 +296,7 @@ void BlimpMessageLogger::LogMessageToStream(const BlimpMessage& message,
   } else {
     // Don't know the human-readable name of |message.type|.
     // Just represent it using its numeric form instead.
-    AddField("type", message.type(), &fields);
+    AddField("type", message.feature_case(), &fields);
   }
 
   // Append "target_tab_id" (if present) and "byte_size" to the field set.