Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: blimp/common/create_blimp_message_unittest.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« blimp/common/create_blimp_message.cc ('K') | « blimp/common/create_blimp_message.cc ('k') | blimp/common/logging.h » ('j') | blimp/common/logging.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/common/create_blimp_message_unittest.cc
diff --git a/blimp/common/create_blimp_message_unittest.cc b/blimp/common/create_blimp_message_unittest.cc
index d2b57dc5488ad63b68cb4830e1867dd8735a1174..5bd501180eff939eec3dd7dd5850762917ca4113 100644
--- a/blimp/common/create_blimp_message_unittest.cc
+++ b/blimp/common/create_blimp_message_unittest.cc
@@ -82,7 +82,7 @@ TEST(CreateBlimpMessageTest, StartConnectionMessage) {
std::unique_ptr<BlimpMessage> message =
CreateStartConnectionMessage(client_token, protocol_version);
EXPECT_NE(nullptr, message);
- EXPECT_EQ(BlimpMessage::PROTOCOL_CONTROL, message->type());
+ EXPECT_TRUE(message->has_protocol_control());
Kevin M 2016/05/02 17:47:48 EXPECT_EQ(kCase, ...)
shaktisahu 2016/05/16 20:19:02 Done.
EXPECT_EQ(ProtocolControlMessage::START_CONNECTION,
message->protocol_control().type());
EXPECT_EQ(client_token,
« blimp/common/create_blimp_message.cc ('K') | « blimp/common/create_blimp_message.cc ('k') | blimp/common/logging.h » ('j') | blimp/common/logging.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698