Used oneof in blimp_message.proto

blimp/common/logging.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/common/logging.h"
 
 #include <iostream>
 #include <string>
 #include <vector>
 
@@ skipping 239 matching lines @@
 
 // No fields are extracted from |message|.
 class NullLogExtractor : public LogExtractor {
   void ExtractFields(const BlimpMessage& message,
                      LogFields* output) const override {}
 };
 
 }  // namespace
 
 BlimpMessageLogger::BlimpMessageLogger() {
-  AddHandler("COMPOSITOR", BlimpMessage::COMPOSITOR,
+  AddHandler("COMPOSITOR", BlimpMessage::kCompositor,
              base::WrapUnique(new CompositorLogExtractor));
-  AddHandler("INPUT", BlimpMessage::INPUT,
+  AddHandler("INPUT", BlimpMessage::kInput,
              base::WrapUnique(new InputLogExtractor));
-  AddHandler("NAVIGATION", BlimpMessage::NAVIGATION,
+  AddHandler("NAVIGATION", BlimpMessage::kNavigation,
              base::WrapUnique(new NavigationLogExtractor));
-  AddHandler("PROTOCOL_CONTROL", BlimpMessage::PROTOCOL_CONTROL,
+  AddHandler("PROTOCOL_CONTROL", BlimpMessage::kProtocolControl,
              base::WrapUnique(new ProtocolControlLogExtractor));
-  AddHandler("RENDER_WIDGET", BlimpMessage::RENDER_WIDGET,
+  AddHandler("RENDER_WIDGET", BlimpMessage::kRenderWidget,
              base::WrapUnique(new RenderWidgetLogExtractor));
-  AddHandler("SETTINGS", BlimpMessage::SETTINGS,
+  AddHandler("SETTINGS", BlimpMessage::kSettings,
              base::WrapUnique(new SettingsLogExtractor));
-  AddHandler("TAB_CONTROL", BlimpMessage::TAB_CONTROL,
+  AddHandler("TAB_CONTROL", BlimpMessage::kTabControl,
              base::WrapUnique(new TabControlLogExtractor));
 }
 
 BlimpMessageLogger::~BlimpMessageLogger() {}
 
 void BlimpMessageLogger::AddHandler(const std::string& type_name,
-                                    BlimpMessage::Type type,
+                                    BlimpMessage::FeatureCase type,

[Kevin M, 2016/05/02 17:47:48]

I'm no naming savant but it seems like a mishmash to have a "case" called
"type". We might want to switch away from the "type" parameter name in favor of
something else? feature_case...? 

[shaktisahu, 2016/05/16 20:19:02]

hmm.. I am open for suggestions. ++wez@
By the way, the 'Case' suffix of FeatureCase was automatically added by the
proto complier to the union name which I named as 'feature'. We can rename
'feature', but cant rid of 'case'

                                     std::unique_ptr<LogExtractor> extractor) {
   DCHECK(extractors_.find(type) == extractors_.end());
   DCHECK(!type_name.empty());
   extractors_[type] = make_pair(type_name, std::move(extractor));
 }
 
 void BlimpMessageLogger::LogMessageToStream(const BlimpMessage& message,
                                             std::ostream* out) const {
   LogFields fields;
 
-  auto extractor = extractors_.find(message.type());
+  auto extractor = extractors_.find(message.feature_case());
   if (extractor != extractors_.end()) {
     // An extractor is registered for |message|.
     // Add the human-readable name of |message.type|.
     fields.push_back(make_pair("type", extractor->second.first));
     extractor->second.second->ExtractFields(message, &fields);
   } else {
     // Don't know the human-readable name of |message.type|.
     // Just represent it using its numeric form instead.
-    AddField("type", message.type(), &fields);
+    AddField("type", message.feature_case(), &fields);
   }
 
   // Append "target_tab_id" (if present) and "byte_size" to the field set.
   if (message.has_target_tab_id()) {
     AddField("target_tab_id", message.target_tab_id(), &fields);
   }
   AddField("byte_size", message.ByteSize(), &fields);
 
   // Format message using the syntax:
   // <BlimpMessage field1=value1 field2="value 2">
   *out << "<BlimpMessage ";
   for (size_t i = 0; i < fields.size(); ++i) {
     *out << fields[i].first << "=" << fields[i].second
          << (i != fields.size() - 1 ? " " : "");
   }
   *out << ">";
 }
 
 std::ostream& operator<<(std::ostream& out, const BlimpMessage& message) {
   g_logger.Get().LogMessageToStream(message, &out);
   return out;
 }
 
 }  // namespace blimp