Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2941)

Unified Diff: blimp/client/feature/render_widget_feature.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/feature/render_widget_feature.cc
diff --git a/blimp/client/feature/render_widget_feature.cc b/blimp/client/feature/render_widget_feature.cc
index e92258de2002cdd2a227f99c7ae0ee1ebd2dcc32..dcad602ac05a8d8dd577e793e2d27d26e1c3e682 100644
--- a/blimp/client/feature/render_widget_feature.cc
+++ b/blimp/client/feature/render_widget_feature.cc
@@ -83,19 +83,18 @@ void RenderWidgetFeature::ProcessMessage(
std::unique_ptr<BlimpMessage> message,
const net::CompletionCallback& callback) {
DCHECK(!callback.is_null());
- DCHECK(message->type() == BlimpMessage::RENDER_WIDGET ||
- message->type() == BlimpMessage::COMPOSITOR);
+ DCHECK(message->has_render_widget() || message->has_compositor());
Kevin M 2016/05/02 17:47:47 Check case
shaktisahu 2016/05/16 20:19:02 Done.
int target_tab_id = message->target_tab_id();
RenderWidgetFeatureDelegate* delegate = FindDelegate(target_tab_id);
DCHECK(delegate) << "RenderWidgetFeatureDelegate not found for "
<< target_tab_id;
- switch (message->type()) {
- case BlimpMessage::RENDER_WIDGET:
+ switch (message->feature_case()) {
+ case BlimpMessage::kRenderWidget:
ProcessRenderWidgetMessage(delegate, message->render_widget());
break;
- case BlimpMessage::COMPOSITOR:
+ case BlimpMessage::kCompositor:
ProcessCompositorMessage(delegate, message->compositor());
break;
default:

Powered by Google App Engine
This is Rietveld 408576698