Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: blimp/client/feature/navigation_feature.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« blimp/client/feature/ime_feature.cc ('K') | « blimp/client/feature/ime_feature.cc ('k') | blimp/client/feature/render_widget_feature.cc » ('j') | blimp/client/feature/render_widget_feature.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/feature/navigation_feature.cc
diff --git a/blimp/client/feature/navigation_feature.cc b/blimp/client/feature/navigation_feature.cc
index 34922363c31c9f7ba0b82d393e55fdf79b318457..787ae2af8cc3fae31e170263deb30f174af71d5c 100644
--- a/blimp/client/feature/navigation_feature.cc
+++ b/blimp/client/feature/navigation_feature.cc
@@ -102,10 +102,9 @@ void NavigationFeature::ProcessMessage(
std::unique_ptr<BlimpMessage> message,
const net::CompletionCallback& callback) {
DCHECK(!callback.is_null());
- DCHECK(message->type() == BlimpMessage::NAVIGATION);
+ DCHECK(message->has_navigation());
Kevin M 2016/05/02 17:47:47 Check case
shaktisahu 2016/05/16 20:19:02 Done.
int tab_id = message->target_tab_id();
- DCHECK(message->has_navigation());
const NavigationMessage& navigation_message = message->navigation();
NavigationFeatureDelegate* delegate = FindDelegate(tab_id);
« blimp/client/feature/ime_feature.cc ('K') | « blimp/client/feature/ime_feature.cc ('k') | blimp/client/feature/render_widget_feature.cc » ('j') | blimp/client/feature/render_widget_feature.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698