Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Unified Diff: blimp/common/create_blimp_message.h

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/common/create_blimp_message.h
diff --git a/blimp/common/create_blimp_message.h b/blimp/common/create_blimp_message.h
index ab8a16dd873e1ea1e89375e3979c6b10ea976e05..57622b983f3d2cd21a67512fb33a8f62e793b274 100644
--- a/blimp/common/create_blimp_message.h
+++ b/blimp/common/create_blimp_message.h
@@ -11,6 +11,7 @@
#include <string>
#include "blimp/common/blimp_common_export.h"
+#include "blimp/common/proto/blimp_message.pb.h"
namespace blimp {
@@ -66,6 +67,9 @@ BLIMP_COMMON_EXPORT std::unique_ptr<BlimpMessage> CreateBlimpMessage(
BLIMP_COMMON_EXPORT std::unique_ptr<BlimpMessage> CreateBlimpMessage(
EngineSettingsMessage** engine_settings);
+BLIMP_COMMON_EXPORT void SetBlimpMessageType(BlimpMessage* message,
Kevin M 2016/05/02 17:47:48 I don't think we should have a function like this,
shaktisahu 2016/05/16 20:19:02 See my comment in the .cc file
+ BlimpMessage::FeatureCase type);
+
BLIMP_COMMON_EXPORT std::unique_ptr<BlimpMessage> CreateStartConnectionMessage(
const std::string& client_token,
int protocol_version);

Powered by Google App Engine
This is Rietveld 408576698