Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: media/cast/test/sender.cc

Issue 193303002: WeakPtr destruction order cleanup: media edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/cast/audio_sender/audio_encoder.cc ('K') | « media/cast/cast_sender_impl.h ('k') | media/cast/test/utility/in_process_receiver.h » ('j') | media/filters/audio_renderer_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/test/sender.cc
diff --git a/media/cast/test/sender.cc b/media/cast/test/sender.cc
index 90d48c94fe93f62634402fa791e44fea31111ed9..c1d9f78fe5ddc4c79cb9a5d88d29741fddf2d42e 100644
--- a/media/cast/test/sender.cc
+++ b/media/cast/test/sender.cc
@@ -310,7 +310,12 @@ class SendProcess {
base::TimeTicks start_time_;
base::TimeTicks send_time_;
scoped_ptr<TestAudioBusFactory> audio_bus_factory_;
+
+ // NOTE: This must always be last so it's invalidated before other member
+ // variables might be accessed.
base::WeakPtrFactory<SendProcess> weak_factory_;
+
+ DISALLOW_COPY_AND_ASSIGN(SendProcess);
Ami GONE FROM CHROMIUM 2014/03/10 22:02:08 Call out in CL description.
DaleCurtis 2014/03/10 23:47:46 Done.
};
} // namespace cast
« media/cast/audio_sender/audio_encoder.cc ('K') | « media/cast/cast_sender_impl.h ('k') | media/cast/test/utility/in_process_receiver.h » ('j') | media/filters/audio_renderer_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698