media/cast/audio_sender/audio_encoder.cc - Issue 193303002: WeakPtr destruction order cleanup: media edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/audio_sender/audio_encoder.cc

Issue 193303002: WeakPtr destruction order cleanup: media edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/cast/audio_sender/audio_encoder.cc

diff --git a/media/cast/audio_sender/audio_encoder.cc b/media/cast/audio_sender/audio_encoder.cc

index efe7a018c01d27c73bcd1e4fe7a1ca2057d951f0..c5c33784d7bbfaa145037244a36f3533170d613c 100644

--- a/media/cast/audio_sender/audio_encoder.cc

+++ b/media/cast/audio_sender/audio_encoder.cc

@@ -171,9 +171,10 @@ class AudioEncoder::ImplBase : public base::SupportsWeakPtr<ImplBase> {

// so far.

uint32 rtp_timestamp_;

+ // NOTE: This must always be last so it's invalidated before other member

+ // variables might be accessed.

base::WeakPtrFactory<ImplBase> weak_factory_;

- private:

Ami GONE FROM CHROMIUM 2014/03/10 22:02:08 PRIVATE!!!

DaleCurtis 2014/03/10 22:10:00 Look up; it was extra private. :)

DISALLOW_COPY_AND_ASSIGN(ImplBase);

};