Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: media/cast/cast_sender_impl.h

Issue 193303002: WeakPtr destruction order cleanup: media edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/cast/audio_sender/audio_encoder.cc ('K') | « media/cast/audio_sender/audio_sender.cc ('k') | media/cast/test/sender.cc » ('j') | media/cast/test/sender.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/cast_sender_impl.h
diff --git a/media/cast/cast_sender_impl.h b/media/cast/cast_sender_impl.h
index 85b8669192a917204ae19a0492913bccae85dc95..aacb9dfa61ba328cc452db206298bc035765defa 100644
--- a/media/cast/cast_sender_impl.h
+++ b/media/cast/cast_sender_impl.h
@@ -57,6 +57,9 @@ class CastSenderImpl : public CastSender {
transport::CastTransportSender* const transport_sender_;
uint32 ssrc_of_audio_sender_;
uint32 ssrc_of_video_sender_;
+
+ // NOTE: This must always be last so it's invalidated before other member
+ // variables might be accessed.
base::WeakPtrFactory<CastSenderImpl> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(CastSenderImpl);
« media/cast/audio_sender/audio_encoder.cc ('K') | « media/cast/audio_sender/audio_sender.cc ('k') | media/cast/test/sender.cc » ('j') | media/cast/test/sender.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698