WeakPtr destruction order cleanup: media edition.

media/cast/audio_sender/audio_encoder.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/cast/audio_sender/audio_encoder.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 153 matching lines @@
   // call.
   int buffer_fill_end_;
 
   // A counter used to label EncodedAudioFrames.
   uint32 frame_id_;
 
   // For audio, rtp_timestamp is computed as the sum of the audio samples seen
   // so far.
   uint32 rtp_timestamp_;
 
+  // NOTE: This must always be last so it's invalidated before other member
+  // variables might be accessed.
   base::WeakPtrFactory<ImplBase> weak_factory_;
 
- private:

[Ami GONE FROM CHROMIUM, 2014/03/10 22:02:08]

PRIVATE!!!

[DaleCurtis, 2014/03/10 22:10:00]

Look up; it was extra private. :)

   DISALLOW_COPY_AND_ASSIGN(ImplBase);
 };
 
 class AudioEncoder::OpusImpl : public AudioEncoder::ImplBase {
  public:
   OpusImpl(CastEnvironment* cast_environment,
            int num_channels,
            int sampling_rate,
            int bitrate,
            const FrameEncodedCallback& callback)
@@ skipping 180 matching lines @@
 
 void AudioEncoder::EncodeAudio(const AudioBus* audio_bus,
                                const base::TimeTicks& recorded_time,
                                const base::Closure& done_callback) {
   DCHECK(cast_environment_->CurrentlyOn(CastEnvironment::AUDIO_ENCODER));
   impl_->EncodeAudio(audio_bus, recorded_time, done_callback);
 }
 
 }  // namespace cast
 }  // namespace media